You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/18 03:07:58 UTC
[GitHub] [flink] cshuo opened a new pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
cshuo opened a new pull request #12208:
URL: https://github.com/apache/flink/pull/12208
…es wrong plan when there exist distinct agg and simple agg with same filter.
## What is the purpose of the change
DecomposeGroupingSetsRule may generates wrong plan when there exist distinct agg and simple agg with same filter, such as the following example:
```
SELECT
h,
COUNT(1) FILTER(WHERE d > 1),
COUNT(DISTINCT e) FILTER(WHERE d > 1)
FROM Table5
GROUP BY h
```
## Brief change log
* This PR fix bugs in `DecomposeGroupingSetsRule`.
## Verifying this change
This change added tests:
* Add integration test in `AggregateITCaseBase` for end-to-end test.
* Add unit test in `DistinctAggregateTestBase`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669",
"triggerID" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f25b5668db8f6c57472286fd839ed8a548ee051b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-629921803
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit f25b5668db8f6c57472286fd839ed8a548ee051b (Mon May 18 03:11:11 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17651).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669",
"triggerID" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f25b5668db8f6c57472286fd839ed8a548ee051b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669",
"triggerID" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"triggerType" : "PUSH"
}, {
"hash" : "4124016011b9f76a8f89c7703d9657ae762c8e17",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2098",
"triggerID" : "4124016011b9f76a8f89c7703d9657ae762c8e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f25b5668db8f6c57472286fd839ed8a548ee051b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669)
* 4124016011b9f76a8f89c7703d9657ae762c8e17 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2098)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cshuo commented on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-631334364
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f25b5668db8f6c57472286fd839ed8a548ee051b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12208:
URL: https://github.com/apache/flink/pull/12208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-629928875
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669",
"triggerID" : "f25b5668db8f6c57472286fd839ed8a548ee051b",
"triggerType" : "PUSH"
}, {
"hash" : "4124016011b9f76a8f89c7703d9657ae762c8e17",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4124016011b9f76a8f89c7703d9657ae762c8e17",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f25b5668db8f6c57472286fd839ed8a548ee051b Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1669)
* 4124016011b9f76a8f89c7703d9657ae762c8e17 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] cshuo commented on pull request #12208: [FLINK-17651][table-planner-blink] DecomposeGroupingSetsRule generat…
Posted by GitBox <gi...@apache.org>.
cshuo commented on pull request #12208:
URL: https://github.com/apache/flink/pull/12208#issuecomment-629921395
@godfreyhe @JingsongLi It's appreciated if you can have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org