You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:24:10 UTC

[GitHub] [airflow] kaxil opened a new pull request #16513: Bugfix: Allow clearing tasks with just ``dag_id`` and empty ``subdir``

kaxil opened a new pull request #16513:
URL: https://github.com/apache/airflow/pull/16513


   Currently if we run the following command:
   
   ```
   airflow tasks clear example_bash_operator --subdir ""
   ```
   
   we get the following error:
   
   ```
   
   Traceback (most recent call last):
     File "/usr/local/bin/airflow", line 33, in <module>
       sys.exit(load_entry_point('apache-airflow', 'console_scripts', 'airflow')())
     File "/opt/airflow/airflow/__main__.py", line 40, in main
       args.func(args)
     File "/opt/airflow/airflow/cli/cli_parser.py", line 48, in command
       return func(*args, **kwargs)
     File "/opt/airflow/airflow/utils/cli.py", line 91, in wrapper
       return f(*args, **kwargs)
     File "/opt/airflow/airflow/cli/commands/task_command.py", line 454, in task_clear
       if args.dag_id and not args.subdir and not args.dag_regex and not args.task_regex:
     File "/opt/airflow/airflow/models/dag.py", line 1413, in clear_dags
       for dag in dags:
   TypeError: 'DAG' object is not iterable
   ```
   
   This is becase `DAG.clear_dags` expects an iterable.
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #16513: Bugfix: Allow clearing tasks with just ``dag_id`` and empty ``subdir``

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #16513:
URL: https://github.com/apache/airflow/pull/16513


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #16513: Bugfix: Allow clearing tasks with just ``dag_id`` and empty ``subdir``

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16513:
URL: https://github.com/apache/airflow/pull/16513#issuecomment-863621097


   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org