You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/10/20 10:45:44 UTC
[GitHub] [incubator-mxnet] bgawrych opened a new pull request #20682: [BUGFIX] Optimize preparation of self attention operators
bgawrych opened a new pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682
## Description ##
This PR fixes problem with redundant double reorder which occurs when dealing with DNNLData
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20682: [BUGFIX] Optimize preparation of self attention operators
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682#issuecomment-958716973
> Is there a test that covers the modified code path?
@szha There is a test for these operators https://github.com/apache/incubator-mxnet/blob/75e4d1d3e41cc5aef9a0141e40127a75e02ccd04/tests/python/dnnl/subgraphs/test_matmul_subgraph.py#L33
These change only removes redundant data reorder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20682: [BUGFIX] Optimize preparation of self attention operators
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682#issuecomment-958716973
> Is there a test that covers the modified code path?
@szha There is a test for these operators https://github.com/apache/incubator-mxnet/blob/75e4d1d3e41cc5aef9a0141e40127a75e02ccd04/tests/python/dnnl/subgraphs/test_matmul_subgraph.py#L33
These change only removes redundant data reorder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #20682: [BUGFIX] Optimize preparation of self attention operators
Posted by GitBox <gi...@apache.org>.
szha merged pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20682: [BUGFIX] Optimize preparation of self attention operators
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682#issuecomment-947546662
Hey @bgawrych , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [windows-cpu, clang, website, sanity, centos-cpu, unix-gpu, centos-gpu, unix-cpu, edge, windows-gpu, miscellaneous]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on pull request #20682: [BUGFIX] Optimize preparation of self attention operators
Posted by GitBox <gi...@apache.org>.
szha commented on pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682#issuecomment-955269412
Is there a test that covers the modified code path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20682: [BUGFIX] Optimize preparation of self attention operators
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682#issuecomment-958716973
> Is there a test that covers the modified code path?
@szha There is a test for these operators https://github.com/apache/incubator-mxnet/blob/75e4d1d3e41cc5aef9a0141e40127a75e02ccd04/tests/python/dnnl/subgraphs/test_matmul_subgraph.py#L33
These change only removes redundant data reorder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] bgawrych commented on pull request #20682: [BUGFIX] Optimize preparation of self attention operators
Posted by GitBox <gi...@apache.org>.
bgawrych commented on pull request #20682:
URL: https://github.com/apache/incubator-mxnet/pull/20682#issuecomment-958716973
> Is there a test that covers the modified code path?
@szha There is a test for these operators https://github.com/apache/incubator-mxnet/blob/75e4d1d3e41cc5aef9a0141e40127a75e02ccd04/tests/python/dnnl/subgraphs/test_matmul_subgraph.py#L33
These change only removes redundant data reorder
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org