[GitHub] [arrow] icexelloss commented on a diff in pull request #34904: GH-34786: [C++] Fix output schema calculated by Substrait consumer for AggregateRel

["icexelloss (via GitHub)" <gi...@apache.org>]

icexelloss commented on code in PR #34904:
URL: https://github.com/apache/arrow/pull/34904#discussion_r1158611677


##########
cpp/src/arrow/acero/aggregate_node.cc:
##########
@@ -77,6 +78,19 @@ namespace acero {
 
 namespace {
 
+template <typename KernelType>
+struct ARROW_ACERO_EXPORT AggregateNodeArgs {

Review Comment:
   I am actually not sure what does `ARROW_ACERO_EXPORT` does but it seems this is a private struct of the cc file and doesn't need to be exported?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org