You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2012/06/09 14:50:43 UTC
[jira] [Created] (LUCENE-4126) Remove FieldType copy constructor
Chris Male created LUCENE-4126:
----------------------------------
Summary: Remove FieldType copy constructor
Key: LUCENE-4126
URL: https://issues.apache.org/jira/browse/LUCENE-4126
Project: Lucene - Java
Issue Type: Improvement
Reporter: Chris Male
Fix For: 4.0, 5.0
Currently FieldTypes can be created using new FieldType(someOtherFieldType) which copies the properties and allows them to then changed. This reduces readability since it hides what properties someOtherFieldType has enabled. We should encourage users (and ourselves) to explicitly state what properties are enabled so to prevent any surprises.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4126) Remove FieldType copy constructor
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292354#comment-13292354 ]
Robert Muir commented on LUCENE-4126:
-------------------------------------
Also i think today, anyone that wants to do things the way you describe can just create the FieldType from scratch already?
they can do this and set everything from scratch, add the field twice, whatever they want :)
But if we remove the ability to do simpler things like 'i want a TextField with term vectors enabled' or 'I want a StringField with index-time boosts', then I think thats a big loss to less advanced users, with no gain to the experts who can already do things from scratch anyway if they prefer to do that.
> Remove FieldType copy constructor
> ---------------------------------
>
> Key: LUCENE-4126
> URL: https://issues.apache.org/jira/browse/LUCENE-4126
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Chris Male
> Fix For: 4.0, 5.0
>
>
> Currently FieldTypes can be created using new FieldType(someOtherFieldType) which copies the properties and allows them to then changed. This reduces readability since it hides what properties someOtherFieldType has enabled. We should encourage users (and ourselves) to explicitly state what properties are enabled so to prevent any surprises.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4126) Remove FieldType copy constructor
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292344#comment-13292344 ]
Chris Male commented on LUCENE-4126:
------------------------------------
Good question.
Currently specifying your own FieldType means you have to use {{Field}} rather than {{StringField}} or {{TextField}} as neither of them accept a FieldType. This is messy and basically the same problem that LUCENE-4101 is fixing for storing. Hmm..
In relation to the the copy constructor issue, for scenario #1 currently users could do:
{code}
FieldType myNewFieldType = new FieldType(TextField.TYPE_STORED);
myNewFieldType.setStoreTermVectors(true);
{code}
With the copy constructor removed, they would need to do:
{code}
FieldType myNewFieldType = new FieldType();
myNewFieldType.setIndexed(...);
myNewFieldType.setStored(...);
... // set other properties
myNewFieldType.setStoreTermVectors(true);
{code}
In the current case the user can easily rely on the pre-existing type and just change the property they're interested in. In their code it would be clear what was changed since no other properties need to be set. At the same time any changes to the pre-existing type would flow into their type without them being notified and they cannot scan over their code and see exactly what properties are set for a field, they'd have to look up the definition.
With the copy constructor removed, we make changing a property more of a task for the user since they would need to define all the properties themselves. Yet at the same time they would be protected from any changes to pre-existing types and they could see in their code exactly what properties were set. But it also wouldn't be so easily to see which property was specifying changed.
I'm not really sure what's best, what do you think?
> Remove FieldType copy constructor
> ---------------------------------
>
> Key: LUCENE-4126
> URL: https://issues.apache.org/jira/browse/LUCENE-4126
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Chris Male
> Fix For: 4.0, 5.0
>
>
> Currently FieldTypes can be created using new FieldType(someOtherFieldType) which copies the properties and allows them to then changed. This reduces readability since it hides what properties someOtherFieldType has enabled. We should encourage users (and ourselves) to explicitly state what properties are enabled so to prevent any surprises.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4126) Remove FieldType copy constructor
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292346#comment-13292346 ]
Robert Muir commented on LUCENE-4126:
-------------------------------------
{quote}
Currently specifying your own FieldType means you have to use Field rather than StringField or TextField as neither of them accept a FieldType. This is messy and basically the same problem that LUCENE-4101 is fixing for storing. Hmm..
{quote}
Actually i think this is ok: these are still expertish things but just not totally crazy.
I dont understand the benefit removing this: having someone create a FieldType from scratch is crazy. Its way too ridiculous: too easy to forget to set tokenized to true or whatever.
Creating a FieldType from scratch is pretty much only useful for committers or people extending things in super-expert ways.
So I think its clear whats best: we have to keep lucene useable.
> Remove FieldType copy constructor
> ---------------------------------
>
> Key: LUCENE-4126
> URL: https://issues.apache.org/jira/browse/LUCENE-4126
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Chris Male
> Fix For: 4.0, 5.0
>
>
> Currently FieldTypes can be created using new FieldType(someOtherFieldType) which copies the properties and allows them to then changed. This reduces readability since it hides what properties someOtherFieldType has enabled. We should encourage users (and ourselves) to explicitly state what properties are enabled so to prevent any surprises.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4126) Remove FieldType copy constructor
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292350#comment-13292350 ]
Chris Male commented on LUCENE-4126:
------------------------------------
I can agree with that
> Remove FieldType copy constructor
> ---------------------------------
>
> Key: LUCENE-4126
> URL: https://issues.apache.org/jira/browse/LUCENE-4126
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Chris Male
> Fix For: 4.0, 5.0
>
>
> Currently FieldTypes can be created using new FieldType(someOtherFieldType) which copies the properties and allows them to then changed. This reduces readability since it hides what properties someOtherFieldType has enabled. We should encourage users (and ourselves) to explicitly state what properties are enabled so to prevent any surprises.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4126) Remove FieldType copy constructor
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13292335#comment-13292335 ]
Robert Muir commented on LUCENE-4126:
-------------------------------------
Lets play out a few typical realistic scenarios that are not too expert:
1. user has a text field and wants to enable term vectors (so they can use highlighting/MLT)
2. user has a string field and wants to enable norms (so they can use index-time boosting)
what does the before/after picture look like here? Is it easier? Is it trappy?
> Remove FieldType copy constructor
> ---------------------------------
>
> Key: LUCENE-4126
> URL: https://issues.apache.org/jira/browse/LUCENE-4126
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Chris Male
> Fix For: 4.0, 5.0
>
>
> Currently FieldTypes can be created using new FieldType(someOtherFieldType) which copies the properties and allows them to then changed. This reduces readability since it hides what properties someOtherFieldType has enabled. We should encourage users (and ourselves) to explicitly state what properties are enabled so to prevent any surprises.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org