[GitHub] [druid] cryptoe commented on a diff in pull request #13263: Add task start status to worker report

[GitBox <gi...@apache.org>]

cryptoe commented on code in PR #13263:
URL: https://github.com/apache/druid/pull/13263#discussion_r1005603064


##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java:
##########
@@ -345,6 +345,26 @@ private void runNewTasks()
     }
   }
 
+  /**
+   * Returns the number of worker tasks not yet in running state or not assigned a location.
+   */
+  public int getPendingWorkerTasks()
+  {
+    synchronized (taskIds) {
+      return desiredTaskCount - fullyStartedTasks.size();

Review Comment:
   ```suggestion
         return desiredTaskCount - getRunningWorkerTasks();
   ```



##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQWorkerTaskLauncher.java:
##########
@@ -345,6 +345,26 @@ private void runNewTasks()
     }
   }
 
+  /**
+   * Returns the number of worker tasks not yet in running state or not assigned a location.

Review Comment:
   ```suggestion
      * Returns the number of worker tasks that are not yet fully started.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org