You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/11/05 05:49:04 UTC
[jira] [Commented] (THRIFT-2768) Whitespace fixups
[ https://issues.apache.org/jira/browse/THRIFT-2768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14197550#comment-14197550 ]
Hudson commented on THRIFT-2768:
--------------------------------
SUCCESS: Integrated in Thrift #1331 (See [https://builds.apache.org/job/Thrift/1331/])
THRIFT-2768: Whitespace Fixup (jensg: rev d5436f5cf7a100d89abb3d125d8f241ca7dc925e)
* lib/delphi/test/multiplexed/Multiplex.Test.Common.pas
* lib/csharp/src/Transport/TNamedPipeServerTransport.cs
* lib/csharp/test/Multiplex/maketest.sh
* lib/delphi/test/typeregistry/TestTypeRegistry.dpr
* lib/delphi/src/Thrift.TypeRegistry.pas
* lib/csharp/test/ThriftTest/TestServer.cs
* lib/csharp/src/Protocol/TProtocol.cs
* lib/delphi/src/Thrift.Server.pas
* tutorial/csharp/CsharpServer/CsharpServer.csproj
* lib/csharp/src/Server/TThreadedServer.cs
* lib/csharp/src/Transport/TServerTransport.cs
* lib/delphi/test/skip/README.md
* lib/csharp/test/Multiplex/Multiplex.Test.Common.cs
* lib/delphi/test/multiplexed/Multiplex.Test.Server.dpr
* lib/csharp/src/Transport/TSocket.cs
* lib/delphi/src/Thrift.Transport.pas
* lib/delphi/src/Thrift.Utils.pas
* lib/delphi/src/Thrift.Collections.pas
* lib/csharp/src/Transport/TTLSServerSocket.cs
* lib/csharp/test/JSON/app.config
* lib/csharp/src/Protocol/TType.cs
* lib/csharp/test/JSON/Properties/AssemblyInfo.cs
* lib/csharp/src/Protocol/TStruct.cs
* lib/delphi/src/Thrift.Transport.Pipes.pas
* lib/csharp/src/Collections/THashSet.cs
* lib/csharp/src/Protocol/TJSONProtocol.cs
* lib/csharp/src/Transport/TTransport.cs
* lib/csharp/src/Collections/TCollections.cs
* tutorial/delphi/Tutorial.groupproj
* tutorial/csharp/CsharpServer/Properties/AssemblyInfo.cs
* tutorial/csharp/CsharpClient/Properties/AssemblyInfo.cs
* lib/csharp/src/Transport/TTransportException.cs
* lib/csharp/src/Transport/TNamedPipeClientTransport.cs
* lib/csharp/src/Protocol/TProtocolFactory.cs
* lib/delphi/src/Thrift.Console.pas
* tutorial/csharp/tutorial.sln
* tutorial/delphi/DelphiClient/DelphiClient.dproj
* lib/csharp/src/Protocol/TList.cs
* lib/delphi/test/codegen/README.md
* lib/csharp/test/JSON/JSONTest.csproj
* tutorial/delphi/DelphiServer/DelphiServer.dproj
* lib/delphi/test/TestServer.pas
* lib/csharp/src/Protocol/TMap.cs
* lib/csharp/src/Protocol/TBinaryProtocol.cs
* lib/delphi/test/multiplexed/Multiplex.Client.Main.pas
* lib/csharp/src/Protocol/TBase.cs
* lib/csharp/src/Transport/TStreamTransport.cs
* lib/csharp/src/Transport/THttpClient.cs
* lib/csharp/src/TProcessor.cs
* lib/csharp/src/Protocol/TSet.cs
* lib/csharp/src/Protocol/TProtocolException.cs
* lib/delphi/src/Thrift.Protocol.pas
* lib/csharp/test/Multiplex/Server/Multiplex.Test.Server.cs
* lib/csharp/src/TException.cs
* lib/csharp/src/Protocol/TField.cs
* lib/delphi/src/Thrift.Processor.Multiplex.pas
* lib/csharp/test/ThriftTest/Program.cs
* lib/csharp/src/Server/TThreadPoolServer.cs
* lib/csharp/src/Protocol/TMessageType.cs
* lib/csharp/src/Transport/THttpHandler.cs
* lib/csharp/src/Protocol/TProtocolUtil.cs
* lib/csharp/src/Protocol/TProtocolDecorator.cs
* lib/csharp/ThriftMSBuildTask/ThriftBuild.cs
* lib/csharp/src/Transport/TServerSocket.cs
* lib/delphi/test/multiplexed/Multiplex.Server.Main.pas
* lib/delphi/src/Thrift.Protocol.Multiplex.pas
* lib/csharp/src/Protocol/TCompactProtocol.cs
* lib/csharp/Makefile.am
* lib/csharp/test/ThriftTest/TestClient.cs
* lib/csharp/src/Transport/TTLSSocket.cs
* lib/csharp/src/Protocol/TMessage.cs
* lib/delphi/test/TestServerEvents.pas
* lib/csharp/src/Thrift.WP7.csproj
* tutorial/csharp/CsharpClient/CsharpClient.csproj
* lib/csharp/test/Multiplex/Client/Multiplex.Test.Client.cs
* lib/csharp/src/Transport/TTransportFactory.cs
* lib/delphi/src/Thrift.Serializer.pas
* lib/delphi/src/Thrift.Stream.pas
* lib/csharp/src/Transport/TFramedTransport.cs
* lib/csharp/src/Thrift.sln
* lib/delphi/test/codegen/run-Pascal-Codegen-Tests.bat.tmpl
* lib/csharp/src/Protocol/TMultiplexedProtocol.cs
* lib/csharp/test/JSON/Program.cs
* lib/csharp/src/Protocol/TAbstractBase.cs
* lib/csharp/src/Protocol/TMultiplexedProcessor.cs
* lib/delphi/test/multiplexed/Multiplex.Test.Client.dpr
* lib/delphi/test/codegen/ReservedKeywords.thrift
* lib/csharp/src/TApplicationException.cs
* lib/csharp/src/Protocol/TBase64Utils.cs
* lib/csharp/src/Transport/TBufferedTransport.cs
* lib/csharp/src/Transport/TMemoryBuffer.cs
* lib/delphi/test/TestClient.pas
* lib/csharp/src/Server/TSimpleServer.cs
* tutorial/csharp/CsharpServer/CsharpServer.cs
THRIFT-2768: Whitespace Fixup (jensg: rev aaa8947f3a149d38dd4bfd395573860c2f18ea93)
* lib/Makefile.am
* tutorial/py.tornado/Makefile.am
* lib/php/Makefile.am
* lib/c_glib/test/Makefile.am
* tutorial/py/Makefile.am
* Makefile.am
* lib/rb/Makefile.am
* lib/d/Makefile.am
* lib/nodejs/examples/user.thrift
* contrib/Rebus/sample.thrift
* tutorial/js/Makefile.am
* lib/js/test/Makefile.am
* tutorial/py.twisted/Makefile.am
* test/AnnotationTest.thrift
* lib/go/test/ServicesTest.thrift
* lib/go/test/Makefile.am
* test/c_glib/Makefile.am
* lib/hs/Makefile.am
* test/cpp/Makefile.am
* test/perl/Makefile.am
* tutorial/go/Makefile.am
* test/rb/Makefile.am
* lib/d/test/Makefile.am
* test/Makefile.am
* tutorial/rb/Makefile.am
* test/php/Makefile.am
* test/py.tornado/Makefile.am
* lib/go/test/MultiplexedProtocolTest.thrift
* lib/go/Makefile.am
* lib/erl/Makefile.am
* lib/nodejs/Makefile.am
* compiler/cpp/Makefile.am
* lib/perl/Makefile.am
* lib/perl/test/Makefile.am
* lib/go/test/GoTagTest.thrift
* tutorial/java/Makefile.am
* contrib/fb303/cpp/Makefile.am
* lib/php/test/Makefile.am
* lib/lua/Makefile.am
* test/go/Makefile.am
* test/NameConflictTest.thrift
* test/hs/Makefile.am
* tutorial/Makefile.am
* lib/go/test/OnewayTest.thrift
* contrib/fb303/py/Makefile.am
* test/ThriftTest.thrift
* test/erl/Makefile.am
* test/DebugProtoTest.thrift
* test/py.twisted/Makefile.am
* lib/py/Makefile.am
* tutorial/hs/Makefile.am
* tutorial/nodejs/Makefile.am
* lib/cpp/test/Makefile.am
* lib/java/Makefile.am
* lib/cpp/Makefile.am
* test/Recursive.thrift
* tutorial/cpp/Makefile.am
* tutorial/c_glib/Makefile.am
* lib/php/test/TestValidators.thrift
* test/py/Makefile.am
THRIFT-2768: Whitespace Fixup (jensg: rev 79f988c27ac97b7a89e6c78a64da2f3a2f65d916)
* tutorial/cpp/Makefile.am
* test/hs/Makefile.am
* lib/nodejs/Makefile.am
* test/cpp/Makefile.am
* lib/cpp/Makefile.am
* lib/perl/Makefile.am
* lib/php/test/Makefile.am
* tutorial/nodejs/Makefile.am
* test/php/Makefile.am
* tutorial/hs/Makefile.am
* test/Makefile.am
* lib/go/Makefile.am
* lib/py/Makefile.am
* test/py/Makefile.am
* contrib/fb303/cpp/Makefile.am
* Makefile.am
* lib/hs/Makefile.am
* test/perl/Makefile.am
* lib/erl/Makefile.am
* lib/d/Makefile.am
* lib/cpp/test/Makefile.am
* tutorial/py/Makefile.am
* tutorial/js/Makefile.am
* test/erl/Makefile.am
* compiler/cpp/Makefile.am
* tutorial/rb/Makefile.am
* tutorial/py.twisted/Makefile.am
* lib/php/Makefile.am
* tutorial/py.tornado/Makefile.am
* test/py.tornado/Makefile.am
* lib/go/test/Makefile.am
* lib/lua/Makefile.am
* lib/c_glib/test/Makefile.am
* test/py.twisted/Makefile.am
* contrib/fb303/py/Makefile.am
* tutorial/java/Makefile.am
* tutorial/go/Makefile.am
* tutorial/Makefile.am
* lib/d/test/Makefile.am
* lib/Makefile.am
* lib/rb/Makefile.am
* test/go/Makefile.am
* lib/java/Makefile.am
* lib/js/test/Makefile.am
* lib/perl/test/Makefile.am
* test/rb/Makefile.am
* tutorial/c_glib/Makefile.am
* test/c_glib/Makefile.am
THRIFT-2768: Whitespace Fixup (jensg: rev 196c5afbb1dcd9f815c055e76b3603bb9acccbb4)
* lib/csharp/Makefile.am
> Whitespace fixups
> -----------------
>
> Key: THRIFT-2768
> URL: https://issues.apache.org/jira/browse/THRIFT-2768
> Project: Thrift
> Issue Type: Sub-task
> Components: C# - Library, Delphi - Library
> Affects Versions: 0.9.2
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Trivial
> Fix For: 0.9.2
>
> Attachments: THRIFT-2768_C#-Whitespace-Fixup.patch, THRIFT-2768_Delphi-Whitespace-Fixup.patch
>
>
> Of course I had to make some content changes. The C# patch file is 354 KB, a lot of files are considered completely replaced. The Delphi patch file has "only" 282 KB.
> The "content" changes are
> (1) one indentation alignment in a batch file, and
> (2) one missing ASF header in a .cs file which I added.
> Anything else is just TABS, SPACEs and CRs. I'm going to commit that. For the records, here are the patch files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)