You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by te...@apache.org on 2016/12/20 16:52:54 UTC
hbase git commit: HBASE-17344 The regionserver web UIs miss the
coprocessors of RegionServerCoprocessorHost (ChiaPing Tsai)
Repository: hbase
Updated Branches:
refs/heads/master a2e967d92 -> e75dee3a2
HBASE-17344 The regionserver web UIs miss the coprocessors of RegionServerCoprocessorHost (ChiaPing Tsai)
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/e75dee3a
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/e75dee3a
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/e75dee3a
Branch: refs/heads/master
Commit: e75dee3a2163182e40400f4eba4599cfbe805c5e
Parents: a2e967d
Author: tedyu <yu...@gmail.com>
Authored: Tue Dec 20 08:52:45 2016 -0800
Committer: tedyu <yu...@gmail.com>
Committed: Tue Dec 20 08:52:45 2016 -0800
----------------------------------------------------------------------
.../hadoop/hbase/regionserver/HRegionServer.java | 1 +
.../org/apache/hadoop/hbase/TestJMXListener.java | 18 +++++++++++++++++-
2 files changed, 18 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/e75dee3a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
index 37fca3c..5bc0a66 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -2928,6 +2928,7 @@ public class HRegionServer extends HasThread implements
LOG.debug("Exception details for failure to fetch wal coprocessor information.", exception);
}
}
+ coprocessors.addAll(rsHost.getCoprocessors());
return coprocessors.toArray(new String[coprocessors.size()]);
}
http://git-wip-us.apache.org/repos/asf/hbase/blob/e75dee3a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXListener.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXListener.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXListener.java
index ed141a6..c3e137f 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXListener.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/TestJMXListener.java
@@ -30,8 +30,10 @@ import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;
import org.apache.hadoop.hbase.testclassification.MediumTests;
import org.apache.hadoop.hbase.testclassification.MiscTests;
+import org.apache.hadoop.hbase.util.JVMClusterUtil;
import org.junit.AfterClass;
import org.junit.Assert;
+import static org.junit.Assert.fail;
import org.junit.BeforeClass;
import org.junit.Rule;
import org.junit.Test;
@@ -93,5 +95,19 @@ public class TestJMXListener {
}
-
+ @Test
+ public void testGetRegionServerCoprocessors() throws Exception {
+ for (JVMClusterUtil.RegionServerThread rs : UTIL.getHBaseCluster().getRegionServerThreads()) {
+ boolean find = false;
+ for (String s : rs.getRegionServer().getRegionServerCoprocessors()) {
+ if (s.equals(JMXListener.class.getSimpleName())) {
+ find = true;
+ break;
+ }
+ }
+ if (!find) {
+ fail("where is the JMXListener?");
+ }
+ }
+ }
}
\ No newline at end of file