You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/05/07 20:53:03 UTC

Re: Review Request 33272: Fix capture by reference of temporary strings in Stout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33272/#review82872
-----------------------------------------------------------

Ship it!


- Joerg Schad


On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33272/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2630
>     https://issues.apache.org/jira/browse/MESOS-2630
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/bytes.hpp 0e8385b106bd8383525df4344a4e49b4df79e0ee 
>   3rdparty/libprocess/3rdparty/stout/include/stout/duration.hpp 8a1626cc7c3fa855f57f531903d0c39e621fff1f 
>   3rdparty/libprocess/3rdparty/stout/include/stout/flags/fetch.hpp 1df982c623ad195b483a0034559e6a488df62ee7 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 00281195b53d2597bdb46e3fe6cd9d46a5e9b1f1 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 343f95be7f316170b37c9358627f3c2090f0e29e 
> 
> Diff: https://reviews.apache.org/r/33272/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>