[GitHub] [nifi] aeaversa commented on a change in pull request #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue

[GitBox <gi...@apache.org>]

aeaversa commented on a change in pull request #3440: NIFI-6221 Adding 'Download' and 'View' content buttons to List Queue
URL: https://github.com/apache/nifi/pull/3440#discussion_r276820693
 
 

 ##########
 File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-queue-listing.js
 ##########
 @@ -675,6 +692,15 @@
                         nfShell.showPage('provenance?' + $.param({
                                 flowFileUuid: item.uuid
                             }));
+                    } else if (target.hasClass('disabled')) {
+                        nfDialog.showOkDialog({
+                            headerText: 'Empty FlowFile',
+                            dialogContent: 'This FlowFile contains no content to complete this action.'
 
 Review comment:
   @patricker - Original motivation was to support users that may not notice the contrast difference on disabled class, especially when its a single FlowFile in the list. But in the end, I can agree with your point. Will revise to your recommendation and get a commit out shortly.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services