You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/04 10:23:37 UTC

[GitHub] [spark] sarutak commented on a change in pull request #30573: [SPARK-26341][CORE]Expose executor memory metrics at the stage level, in the Stages tab

sarutak commented on a change in pull request #30573:
URL: https://github.com/apache/spark/pull/30573#discussion_r535993346



##########
File path: core/src/main/scala/org/apache/spark/status/api/v1/api.scala
##########
@@ -86,7 +86,7 @@ class ExecutorStageSummary private[spark](
     val isBlacklistedForStage: Boolean,
     @JsonSerialize(using = classOf[ExecutorMetricsJsonSerializer])
     @JsonDeserialize(using = classOf[ExecutorMetricsJsonDeserializer])
-    val peakMemoryMetrics: Option[ExecutorMetrics],
+    val peakMemoryMetrics: ExecutorMetrics,

Review comment:
       How about checking whether `row` has `peakMemoryMetrics` in `stagepages.js`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org