You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "ByteBaker (via GitHub)" <gi...@apache.org> on 2025/07/19 16:24:35 UTC
[PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
ByteBaker opened a new pull request, #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #263 .
# Rationale for this change
User convenience.
# What changes are included in this PR?
Re-export `HeaderMap`, `HeaderValue`, and `Extensions` from http crate to avoid forcing users to add http dependency when using object_store public API.
# Are there any user-facing changes?
The types `HeaderMap`, `HeaderValue`, and `Extensions` can now be accessed directly from object-store without adding http as a separate dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "ByteBaker (via GitHub)" <gi...@apache.org>.
ByteBaker commented on code in PR #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441#discussion_r2220170246
##########
src/lib.rs:
##########
@@ -567,6 +567,16 @@ pub use payload::*;
pub use upload::*;
pub use util::{coalesce_ranges, collect_bytes, GetRange, OBJECT_STORE_COALESCE_DEFAULT};
+/// Type alias for HTTP extensions used in object store operations
Review Comment:
Will update the code and push again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "ByteBaker (via GitHub)" <gi...@apache.org>.
ByteBaker closed pull request #441: feat: re-export HTTP types used in public API
URL: https://github.com/apache/arrow-rs-object-store/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "ByteBaker (via GitHub)" <gi...@apache.org>.
ByteBaker commented on PR #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441#issuecomment-3127433362
@tustvold I've made the changes. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "ByteBaker (via GitHub)" <gi...@apache.org>.
ByteBaker commented on code in PR #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441#discussion_r2220169250
##########
src/lib.rs:
##########
@@ -567,6 +567,16 @@ pub use payload::*;
pub use upload::*;
pub use util::{coalesce_ranges, collect_bytes, GetRange, OBJECT_STORE_COALESCE_DEFAULT};
+/// Type alias for HTTP extensions used in object store operations
Review Comment:
To be honest I didn't think of it much. At the moment it felt cleaner rather than to use `::http::Extensions` everywhere. But I guess I could put it next to the other two imports and it won't change a thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "ByteBaker (via GitHub)" <gi...@apache.org>.
ByteBaker commented on PR #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441#issuecomment-3092598061
Pushed again after resolving CI issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441#discussion_r2218473774
##########
src/lib.rs:
##########
@@ -567,6 +567,16 @@ pub use payload::*;
pub use upload::*;
pub use util::{coalesce_ranges, collect_bytes, GetRange, OBJECT_STORE_COALESCE_DEFAULT};
+/// Type alias for HTTP extensions used in object store operations
Review Comment:
What's the motivation for using a type alias Vs re-exporting the http type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: re-export HTTP types used in public API [arrow-rs-object-store]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #441:
URL: https://github.com/apache/arrow-rs-object-store/pull/441#discussion_r2236568540
##########
src/lib.rs:
##########
@@ -567,6 +567,16 @@ pub use payload::*;
pub use upload::*;
pub use util::{coalesce_ranges, collect_bytes, GetRange, OBJECT_STORE_COALESCE_DEFAULT};
+/// Type alias for HTTP extensions used in object store operations
Review Comment:
I think I would prefer a re-export, as I think it is potentially confusing otherwise - can the types be used interchangeably or should people use object_store::Extensions in case we redefine it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org