[jira] [Commented] (SOLR-15943) Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376

["Houston Putman (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17494220#comment-17494220 ] 

Houston Putman commented on SOLR-15943:
---------------------------------------

Why override the methods at all?

> Simplify HDFS cache to account for LUCENE-10366 / LUCENE-10376
> --------------------------------------------------------------
>
>                 Key: SOLR-15943
>                 URL: https://issues.apache.org/jira/browse/SOLR-15943
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Hadoop Integration, hdfs
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> LUCENE-10366 / LUCENE-10376 found that the loop unrolling isn't necessary anymore. SOLR-15405 implemented the little endian loop unrolling, but this can be simplified to avoid issues in the future.
> Example of what is needed: https://github.com/apache/lucene/pull/592 and https://github.com/apache/lucene/pull/602
> {code:java}
>   @Override
>   public final int readVInt() throws IOException {
>     // this can make JVM less confused (see LUCENE-10366)
>     return super.readVInt();
>   }
>   @Override
>   public final long readVLong() throws IOException {
>     // this can make JVM less confused (see LUCENE-10366)
>     return super.readVLong();
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org