You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2014/10/24 17:26:12 UTC
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/302
[STORM-533] Added in client and server IConnection metrics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm iconn-metrics
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/302.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #302
----
commit b6142189005a6741b6996fc08cec759c1082bc17
Author: Robert (Bobby) Evans <ev...@yahoo-inc.com>
Date: 2014-10-16T17:54:35Z
[STORM-533] Added in client and server IConnection metrics.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-63340062
Thanks for the comments on this. I merged it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-61722105
Btw, I think it's amazing to have connection / transmitted status metric. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by clockfly <gi...@git.apache.org>.
Github user clockfly commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-61658959
+1 for the ideas. We should have more metrics about the connection status.
From other side, current storm metric system code is too hard to read and too hard to use.
Maybe we should use mature library like codahale to ease this process, instead of maintaining our own metric facility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-61989690
The metrics system is very generic, and not that complex. Essentially it sets up a timer that will periodically call getValueAndReset on an instance of IMetric. These values can be anything and are sent to an instance of IMetricsConsumer that is residing in a bolt. It is up to the IMetricsConsumer to decide what to do with Object the the IMetric created.
I agree that having an API closer to codahale would be good, but that is a much bigger change. I would like to see that in a separate JIRA/pull request. The big difference between the two approaches is that the storm metrics associate the value with an individual bolt or spout instance. codahale and most other metrics systems I have seen, associate the metrics with an arbitrary name. We would need a way to bridge that gap in a clean/efficient way. I would also like to see a lot of metrics added into the daemon processes. Nimbus, Supervisor, and DRPC all need good monitoring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-61990146
@clockfly what specifically about the status of the connection do you want?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-61721876
I agreed to @clockfly. I also think it would be better to make metrics easier to add.
Actually I was spending a time to contribute STORM-533, but I cannot understand current storm metric system so I cannot even try it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/302
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-63134572
@clockfly is it OK to merge this code in? I am happy to file a new JIRA for rethinking how we do metrics in storm, if you think that would be helpful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-63128505
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-533] Added in client and server IConnec...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-63138277
@revans2 I think we can merge this and open a JIRA for discussing changing the metrics infrastructure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---