You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/09 19:15:53 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #802: system/nxlooper: Fix the following compiler warning
xiaoxiang781216 opened a new pull request #802:
URL: https://github.com/apache/incubator-nuttx-apps/pull/802
## Summary
```
nxlooper.c: In function 'nxlooper_opendevice':
Error: nxlooper.c:126:15: error: unused variable 'x' [-Werror=unused-variable]
126 | uint8_t x;
| ^
Error: nxlooper.c:125:15: error: unused variable 'supported' [-Werror=unused-variable]
125 | uint8_t supported = true;
| ^~~~~~~~~
In file included from nxlooper.c:40:
nxlooper.c: In function 'nxlooper_loopthread':
Error: nxlooper.c:482:15: error: format '%d' expects argument of type 'int', but argument 3 has type 'ssize_t' {aka 'long int'} [-Werror=format=]
482 | audinfo("message received size %d id%d\n", size, msg.msg_id);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ~~~~
| |
| ssize_t {aka long int}
nxlooper.c:482:39: note: format string is defined here
482 | audinfo("message received size %d id%d\n", size, msg.msg_id);
| ~^
| |
| int
| %ld
cc1: all warnings being treated as errors
make[3]: *** [/github/workspace/sources/apps/Application.mk:133: nxlooper.c.github.workspace.sources.apps.system.nxlooper.o] Error 1
nxlooper_main.c: In function 'nxlooper_cmd_loopback':
Error: nxlooper_main.c:209:9: error: implicit declaration of function 'nxlooper_loopraw'; did you mean 'nxlooper_stop'? [-Werror=implicit-function-declaration]
209 | ret = nxlooper_loopraw(plooper, channels, bpsamp,
| ^~~~~~~~~~~~~~~~
| nxlooper_stop
```
## Impact
Make https://github.com/apache/incubator-nuttx/pull/4108 pass CI
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #802: system/nxlooper: Fix the following compiler warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #802:
URL: https://github.com/apache/incubator-nuttx-apps/pull/802#discussion_r667315844
##########
File path: include/system/nxlooper.h
##########
@@ -161,6 +161,32 @@ void nxlooper_reference(FAR struct nxlooper_s *plooper);
int nxlooper_setdevice(FAR struct nxlooper_s *plooper,
FAR const char *device);
+/****************************************************************************
+ * Name: nxlooper_loopraw
+ *
+ * nxlooper_loopraw() tries to record and then play the raw data using the
+ * Audio system. If a device is specified, it will try to use that
+ * device.
+ * Input:
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #802: system/nxlooper: Fix the following compiler warning
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #802:
URL: https://github.com/apache/incubator-nuttx-apps/pull/802#discussion_r667315687
##########
File path: include/system/nxlooper.h
##########
@@ -161,6 +161,32 @@ void nxlooper_reference(FAR struct nxlooper_s *plooper);
int nxlooper_setdevice(FAR struct nxlooper_s *plooper,
FAR const char *device);
+/****************************************************************************
+ * Name: nxlooper_loopraw
+ *
Review comment:
All nxplayer.h/nxrecorder.h/nxlooper.h don't have this. It's better to fix the problem by new patch, do you think so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #802: system/nxlooper: Fix the following compiler warning
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #802:
URL: https://github.com/apache/incubator-nuttx-apps/pull/802#discussion_r667323651
##########
File path: include/system/nxlooper.h
##########
@@ -161,6 +161,32 @@ void nxlooper_reference(FAR struct nxlooper_s *plooper);
int nxlooper_setdevice(FAR struct nxlooper_s *plooper,
FAR const char *device);
+/****************************************************************************
+ * Name: nxlooper_loopraw
+ *
Review comment:
Ok, seems reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #802: system/nxlooper: Fix the following compiler warning
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #802:
URL: https://github.com/apache/incubator-nuttx-apps/pull/802#discussion_r667208454
##########
File path: include/system/nxlooper.h
##########
@@ -161,6 +161,32 @@ void nxlooper_reference(FAR struct nxlooper_s *plooper);
int nxlooper_setdevice(FAR struct nxlooper_s *plooper,
FAR const char *device);
+/****************************************************************************
+ * Name: nxlooper_loopraw
+ *
+ * nxlooper_loopraw() tries to record and then play the raw data using the
+ * Audio system. If a device is specified, it will try to use that
+ * device.
+ * Input:
Review comment:
```suggestion
*
* Input Parameters:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei merged pull request #802: system/nxlooper: Fix the following compiler warning
Posted by GitBox <gi...@apache.org>.
gustavonihei merged pull request #802:
URL: https://github.com/apache/incubator-nuttx-apps/pull/802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] gustavonihei commented on a change in pull request #802: system/nxlooper: Fix the following compiler warning
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on a change in pull request #802:
URL: https://github.com/apache/incubator-nuttx-apps/pull/802#discussion_r667208361
##########
File path: include/system/nxlooper.h
##########
@@ -161,6 +161,32 @@ void nxlooper_reference(FAR struct nxlooper_s *plooper);
int nxlooper_setdevice(FAR struct nxlooper_s *plooper,
FAR const char *device);
+/****************************************************************************
+ * Name: nxlooper_loopraw
+ *
Review comment:
```suggestion
*
* Description:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org