You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "rdhabalia (via GitHub)" <gi...@apache.org> on 2023/02/27 20:04:47 UTC

[GitHub] [bookkeeper] rdhabalia opened a new pull request, #3822: Fix: bookie-shell ledger-metadata usage with correct param

rdhabalia opened a new pull request, #3822:
URL: https://github.com/apache/bookkeeper/pull/3822

   ### Motivation
   
   `./bin/bookkeeper shell ledgermetadata` usage is showing incorrect params `dump-to-file` , `restore-from` to user while executing the command.
   
   ### Changes
   
   Fix usage with correct param `dumptofile` and `restorefromfile`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] codecov-commenter commented on pull request #3822: Fix: bookie-shell ledger-metadata usage with correct param

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3822:
URL: https://github.com/apache/bookkeeper/pull/3822#issuecomment-1447031273

   # [Codecov](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3822](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (67b2aa5) into [master](https://codecov.io/gh/apache/bookkeeper/commit/c389b96f12cd8dbcb654acc84234afe3f981f698?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c389b96) will **decrease** coverage by `26.52%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #3822       +/-   ##
   =============================================
   - Coverage     47.46%   20.94%   -26.52%     
   + Complexity     4570     2005     -2565     
   =============================================
     Files           473      473               
     Lines         40963    40963               
     Branches       5240     5240               
   =============================================
   - Hits          19443     8580    -10863     
   - Misses        19524    31107    +11583     
   + Partials       1996     1276      -720     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | remaining | `?` | |
   | replication | `?` | |
   | tls | `20.94% <0.00%> (-0.05%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...java/org/apache/bookkeeper/bookie/BookieShell.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvYm9va2llL0Jvb2tpZVNoZWxsLmphdmE=) | `0.00% <0.00%> (-0.68%)` | :arrow_down: |
   | [.../java/org/apache/bookkeeper/util/SubTreeCache.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvdXRpbC9TdWJUcmVlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rg/apache/bookkeeper/metastore/MetastoreTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../apache/bookkeeper/meta/UnderreplicatedLedger.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9VbmRlcnJlcGxpY2F0ZWRMZWRnZXIuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...he/bookkeeper/server/conf/BookieConfiguration.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2NvbmYvQm9va2llQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../bookkeeper/metastore/MetastoreScannableTable.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YXN0b3JlL01ldGFzdG9yZVNjYW5uYWJsZVRhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...bookkeeper/meta/LedgerUnderreplicationManager.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWV0YS9MZWRnZXJVbmRlcnJlcGxpY2F0aW9uTWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...bookkeeper/proto/checksum/CRC32CDigestManager.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvcHJvdG8vY2hlY2tzdW0vQ1JDMzJDRGlnZXN0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...bookkeeper/server/http/service/MetricsService.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL2h0dHAvc2VydmljZS9NZXRyaWNzU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ookkeeper/server/service/StatsProviderService.java](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Ym9va2tlZXBlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvc2VydmVyL3NlcnZpY2UvU3RhdHNQcm92aWRlclNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [263 more](https://codecov.io/gh/apache/bookkeeper/pull/3822?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [bookkeeper] merlimat merged pull request #3822: Fix: bookie-shell ledger-metadata usage with correct param

Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #3822:
URL: https://github.com/apache/bookkeeper/pull/3822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org