You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com> on 2016/09/01 17:24:52 UTC
Re: Review Request 51252: SAMZA-1004: Fix some logging and javadoc
issues for AsyncStreamTask
> On Aug. 30, 2016, 10:37 p.m., Prateek Maheshwari wrote:
> > samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java, line 25
> > <https://reviews.apache.org/r/51252/diff/2/?file=1488893#file1488893line25>
> >
> > multithreaded.
> >
> > Maybe use asynchronous instead of multithreaded here? Multi-threaded seems like an implementation detail.
Maybe "asynchronous execution in a multi-threaded Samza container" is more accurate?
- Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51252/#review147373
-----------------------------------------------------------
On Aug. 30, 2016, 10:01 p.m., Xinyu Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51252/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2016, 10:01 p.m.)
>
>
> Review request for samza, Navina Ramesh and Yi Pan (Data Infrastructure).
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-1004: Fix some logging and javadoc issues for AsyncStreamTask
>
>
> Diffs
> -----
>
> samza-api/src/main/java/org/apache/samza/task/AsyncStreamTask.java 684ba0b77fca1c1c5fd8d740597d3b7fcdc0f5cb
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala f786fc08c8f7eced4f4084dc8326b288888b6422
>
> Diff: https://reviews.apache.org/r/51252/diff/
>
>
> Testing
> -------
>
> gradlew clean build.
>
>
> Thanks,
>
> Xinyu Liu
>
>