[GitHub] [incubator-superset] rusackas commented on pull request #10257: feat: minor reorder SQL Lab Tab controls

[GitBox <gi...@apache.org>]

rusackas commented on pull request #10257:
URL: https://github.com/apache/incubator-superset/pull/10257#issuecomment-655774710


   I'm in total agreement that the status dot acting as a close button is a dangerous pattern.
   
   If closing the tab is a risk, would it be reasonable to remove the X button from the new design as well, and require that users click the ⠇menu and select "close tab" to close the tab?
   
   If that's reasonable, I think the menu (whether a ⠇or a ˅ ) would be better back on the right side of the tab. I'm a bit ambivalent about whether the status dot should be to the left or right of the title.
   
   **In other words** would it make sense to just remove the "X" close button from the status dot and call it a day?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org