You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2019/04/15 01:25:33 UTC
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13016
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
IMPALA-8414: Skip header when parsing /proc/net/dev
The fix for IMPALA-8395 does not skip the first to header lines of
/proc/net/dev. This change skips the header to prevent unnecessary
warnings.
Testing: Manually checked that impalad.WARNING did not contain any
warnings about failure to parse /proc/net/dev.
Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
---
M be/src/util/system-state-info.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/13016/1
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 )
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Rebased, addressed comment, carrying Michael's +2.
http://gerrit.cloudera.org:8080/#/c/13016/1/be/src/util/system-state-info.cc
File be/src/util/system-state-info.cc:
http://gerrit.cloudera.org:8080/#/c/13016/1/be/src/util/system-state-info.cc@174
PS1, Line 174: const StringPiece
> const StringPiece&
Done
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 17:05:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 )
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 22:08:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 )
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13016/1/be/src/util/system-state-info.cc
File be/src/util/system-state-info.cc:
http://gerrit.cloudera.org:8080/#/c/13016/1/be/src/util/system-state-info.cc@174
PS1, Line 174: const StringPiece
const StringPiece&
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Apr 2019 23:09:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 )
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4049/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 17:05:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13016
to look at the new patch set (#2).
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
IMPALA-8414: Skip header when parsing /proc/net/dev
The fix for IMPALA-8395 does not skip the first to header lines of
/proc/net/dev. This change skips the header to prevent unnecessary
warnings.
Testing: Manually checked that impalad.WARNING did not contain any
warnings about failure to parse /proc/net/dev.
Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
---
M be/src/util/system-state-info.cc
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/16/13016/2
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 )
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2776/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 1
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Apr 2019 02:10:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13016 )
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
IMPALA-8414: Skip header when parsing /proc/net/dev
The fix for IMPALA-8395 does not skip the first to header lines of
/proc/net/dev. This change skips the header to prevent unnecessary
warnings.
Testing: Manually checked that impalad.WARNING did not contain any
warnings about failure to parse /proc/net/dev.
Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Reviewed-on: http://gerrit.cloudera.org:8080/13016
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/system-state-info.cc
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 3
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-8414: Skip header when parsing /proc/net/dev
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13016 )
Change subject: IMPALA-8414: Skip header when parsing /proc/net/dev
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2846/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13016
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ff931671050d44926d0baa77ec374afed1f8225
Gerrit-Change-Number: 13016
Gerrit-PatchSet: 2
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Apr 2019 17:24:17 +0000
Gerrit-HasComments: No