You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/23 11:42:25 UTC
[GitHub] [airflow] kaxil opened a new pull request #7512: [AIRFLOW-6889]
Change mutable argument value in OpsgenieAlertHook
kaxil opened a new pull request #7512: [AIRFLOW-6889] Change mutable argument value in OpsgenieAlertHook
URL: https://github.com/apache/airflow/pull/7512
**OpsgenieAlertHook** contains the following code which uses a mutable argument value.
```python
def execute(self, payload={}):
```
Reference: https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7512: [AIRFLOW-6889]
Change mutable argument value in OpsgenieAlertHook
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7512: [AIRFLOW-6889] Change mutable argument value in OpsgenieAlertHook
URL: https://github.com/apache/airflow/pull/7512#issuecomment-590063148
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=h1) Report
> Merging [#7512](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0bb687990b94da7445f4ba081592de8cea73119e?src=pr&el=desc) will **decrease** coverage by `0.45%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7512/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7512 +/- ##
==========================================
- Coverage 86.81% 86.35% -0.46%
==========================================
Files 893 893
Lines 42186 42187 +1
==========================================
- Hits 36622 36432 -190
- Misses 5564 5755 +191
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/opsgenie/hooks/opsgenie\_alert.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3BzZ2VuaWUvaG9va3Mvb3BzZ2VuaWVfYWxlcnQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=footer). Last update [0bb6879...1204f60](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7512: [AIRFLOW-6889] Change
mutable argument value in OpsgenieAlertHook
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7512: [AIRFLOW-6889] Change mutable argument value in OpsgenieAlertHook
URL: https://github.com/apache/airflow/pull/7512
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7512:
[AIRFLOW-6889] Change mutable argument value in OpsgenieAlertHook
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7512: [AIRFLOW-6889] Change mutable argument value in OpsgenieAlertHook
URL: https://github.com/apache/airflow/pull/7512#issuecomment-590063148
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=h1) Report
> Merging [#7512](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0bb687990b94da7445f4ba081592de8cea73119e?src=pr&el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `100%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/airflow/pull/7512/graphs/tree.svg?width=650&token=WdLKlKHOAU&height=150&src=pr)](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7512 +/- ##
==========================================
- Coverage 86.81% 86.52% -0.29%
==========================================
Files 893 893
Lines 42186 42187 +1
==========================================
- Hits 36622 36504 -118
- Misses 5564 5683 +119
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/providers/opsgenie/hooks/opsgenie\_alert.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvb3BzZ2VuaWUvaG9va3Mvb3BzZ2VuaWVfYWxlcnQucHk=) | `100% <100%> (ø)` | :arrow_up: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0%> (-55.56%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0%> (-47.06%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0%> (-45.08%)` | :arrow_down: |
| [...viders/cncf/kubernetes/operators/kubernetes\_pod.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvY25jZi9rdWJlcm5ldGVzL29wZXJhdG9ycy9rdWJlcm5ldGVzX3BvZC5weQ==) | `69.38% <0%> (-25.52%)` | :arrow_down: |
| [airflow/kubernetes/refresh\_config.py](https://codecov.io/gh/apache/airflow/pull/7512/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3JlZnJlc2hfY29uZmlnLnB5) | `50.98% <0%> (-23.53%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=footer). Last update [0bb6879...1204f60](https://codecov.io/gh/apache/airflow/pull/7512?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services