You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by bowenli86 <gi...@git.apache.org> on 2017/09/22 23:15:58 UTC
[GitHub] flink pull request #4708: [FLINK-7393][kinesis connector] Move unit tests th...
GitHub user bowenli86 opened a pull request:
https://github.com/apache/flink/pull/4708
[FLINK-7393][kinesis connector] Move unit tests that should belong to KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest
## What is the purpose of the change
Right now, `FlinkKinesisConsumerTest` has lots of unit tests that actually should belong to `KinesisConfigUtil`, e.g. all the `validateXxxConfiguration()`
We need to move those tests out to a new file `KinesisConfigUtilTest`
## Brief change log
- Move unit tests that should belong to KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests, such as *(please describe tests)*.
## Does this pull request potentially affect one of the following parts:
none
## Documentation
none
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bowenli86/flink FLINK-7223
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4708.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4708
----
commit 8ba44053ea96220fd74a357ff612bebf65553cb7
Author: Bowen Li <bo...@gmail.com>
Date: 2017-09-22T23:10:56Z
FLINK-7393 Move unit tests of KinesisConfigUtil from FlinkKinesisConsumerTest to KinesisConfigUtilTest
----
---
[GitHub] flink issue #4708: [FLINK-7393][kinesis connector] Move unit tests that shou...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4708
@tzulitai yes, only unit tests migration
---
[GitHub] flink issue #4708: [FLINK-7393][kinesis connector] Move unit tests that shou...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4708
Thanks @bowenli86.
Looks like a only a migration of unit tests, correct? LGTM, will merge this.
---
[GitHub] flink pull request #4708: [FLINK-7393][kinesis connector] Move unit tests th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4708
---
[GitHub] flink issue #4708: [FLINK-7393][kinesis connector] Move unit tests that shou...
Posted by bowenli86 <gi...@git.apache.org>.
Github user bowenli86 commented on the issue:
https://github.com/apache/flink/pull/4708
cc @tzulitai
---