You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/03/21 10:34:58 UTC
Review Request 66194: ATLAS-2508 : When adding validityPeriod ,
default value shown in UI is not taken by the POST request
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66194/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
Bugs: ATLAS-2508
https://issues.apache.org/jira/browse/ATLAS-2508
Repository: atlas
Description
-------
When Apply Validity Period check box is checked , default value for start time and end time is applied
Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e)
Start time : Today's Date Current time
End time : Todays's Date 11:59 PM
and no timezone is selected by default.
But the POST request is sent as
"validityPeriods":[
{"startTime":"","endTime":"","timeZone":""}
]}
Diffs
-----
dashboardv2/public/js/views/tag/AddTimezoneItemView.js 420303f
Diff: https://reviews.apache.org/r/66194/diff/1/
Testing
-------
Done one round of sanity testing.
Thanks,
pratik pandey
Re: Review Request 66194: ATLAS-2508 : When adding validityPeriod ,
default value shown in UI is not taken by the POST request
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66194/#review199988
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 21, 2018, 12:16 p.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66194/
> -----------------------------------------------------------
>
> (Updated March 21, 2018, 12:16 p.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
>
>
> Bugs: ATLAS-2508
> https://issues.apache.org/jira/browse/ATLAS-2508
>
>
> Repository: atlas
>
>
> Description
> -------
>
> When Apply Validity Period check box is checked , default value for start time and end time is applied
> Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e)
> Start time : Today's Date Current time
> End time : Todays's Date 11:59 PM
>
> and no timezone is selected by default.
>
> But the POST request is sent as
> "validityPeriods":[
>
> {"startTime":"","endTime":"","timeZone":""}
> ]}
>
>
> Diffs
> -----
>
> dashboardv2/public/js/views/tag/AddTimezoneItemView.js 420303f
>
>
> Diff: https://reviews.apache.org/r/66194/diff/3/
>
>
> Testing
> -------
>
> Done one round of sanity testing.
>
>
> Thanks,
>
> pratik pandey
>
>
Re: Review Request 66194: ATLAS-2508 : When adding validityPeriod ,
default value shown in UI is not taken by the POST request
Posted by pratik pandey <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66194/
-----------------------------------------------------------
(Updated March 21, 2018, 12:16 p.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
Changes
-------
single dateObject for create and edit.
Bugs: ATLAS-2508
https://issues.apache.org/jira/browse/ATLAS-2508
Repository: atlas
Description
-------
When Apply Validity Period check box is checked , default value for start time and end time is applied
Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e)
Start time : Today's Date Current time
End time : Todays's Date 11:59 PM
and no timezone is selected by default.
But the POST request is sent as
"validityPeriods":[
{"startTime":"","endTime":"","timeZone":""}
]}
Diffs (updated)
-----
dashboardv2/public/js/views/tag/AddTimezoneItemView.js 420303f
Diff: https://reviews.apache.org/r/66194/diff/2/
Changes: https://reviews.apache.org/r/66194/diff/1-2/
Testing
-------
Done one round of sanity testing.
Thanks,
pratik pandey