You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by "Digy (JIRA)" <ji...@apache.org> on 2009/11/30 13:06:21 UTC
[jira] Created: (LUCENENET-313) SharpZipLib dependency
SharpZipLib dependency
----------------------
Key: LUCENENET-313
URL: https://issues.apache.org/jira/browse/LUCENENET-313
Project: Lucene.Net
Issue Type: Improvement
Reporter: Digy
Attachments: SharpZipLib Dependency.patch
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
RE: [jira] Resolved: (LUCENENET-313) SharpZipLib dependency
Posted by Digy <di...@gmail.com>.
My bad. I committed the new project file.
Thanks Michael.
DIGY
-----Original Message-----
From: Michael Garski [mailto:mgarski@myspace-inc.com]
Sent: Tuesday, December 01, 2009 7:18 PM
To: lucene-net-dev@incubator.apache.org
Subject: RE: [jira] Resolved: (LUCENENET-313) SharpZipLib dependency
I just tried a build after the commit and the project file needs to be updated to reflect the deletion of the SharpZopLibAdapter.
Error 1 Source file 'C:\SVN Projects\Lucene.Net\trunk\C#\src\Lucene.Net\SharpZipLibAdapter.cs' could not be opened ('Unspecified error ') Lucene.Net
Michael
-----Original Message-----
From: Digy (JIRA) [mailto:jira@apache.org]
Sent: Tuesday, December 01, 2009 8:58 AM
To: lucene-net-dev@incubator.apache.org
Subject: [jira] Resolved: (LUCENENET-313) SharpZipLib dependency
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy resolved LUCENENET-313.
----------------------------
Resolution: Fixed
I committed the patch for CompressionTools and removed SupportClass.CompressionSupport and SharpZipLibAdapter.cs.
But I left the project file as it was.
DIGY
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
RE: [jira] Resolved: (LUCENENET-313) SharpZipLib dependency
Posted by Michael Garski <mg...@myspace-inc.com>.
I just tried a build after the commit and the project file needs to be updated to reflect the deletion of the SharpZopLibAdapter.
Error 1 Source file 'C:\SVN Projects\Lucene.Net\trunk\C#\src\Lucene.Net\SharpZipLibAdapter.cs' could not be opened ('Unspecified error ') Lucene.Net
Michael
-----Original Message-----
From: Digy (JIRA) [mailto:jira@apache.org]
Sent: Tuesday, December 01, 2009 8:58 AM
To: lucene-net-dev@incubator.apache.org
Subject: [jira] Resolved: (LUCENENET-313) SharpZipLib dependency
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy resolved LUCENENET-313.
----------------------------
Resolution: Fixed
I committed the patch for CompressionTools and removed SupportClass.CompressionSupport and SharpZipLibAdapter.cs.
But I left the project file as it was.
DIGY
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (LUCENENET-313) SharpZipLib dependency
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy resolved LUCENENET-313.
----------------------------
Resolution: Fixed
I committed the patch for CompressionTools and removed SupportClass.CompressionSupport and SharpZipLibAdapter.cs.
But I left the project file as it was.
DIGY
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-313) SharpZipLib dependency
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784235#action_12784235 ]
George Aroush commented on LUCENENET-313:
-----------------------------------------
Thanks DIGY! Commit away and +1 for removing SupportClass.CompressionSupport and SharpZipLibAdapter.cs.
Also, I see this patch as a temporally solution. If we build our binary with this patch, those who just use the binary distribution of Lucene.Net won't have access to compressed fields. So, we need another JIRA issue to take this task further; Lucene.Net should dynamically load and enable SharpZipLib support. Is reflections tricks the answer?
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-313) SharpZipLib dependency
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-313:
---------------------------
Description:
With the patch, SharpZipLib is not a "must".
(but no compression support)
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-313) SharpZipLib dependency
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784293#action_12784293 ]
Digy commented on LUCENENET-313:
--------------------------------
{quote}
Lucene 3.0 has some changes regarding compressed fields: 2.9 already deprecated compressed fields; support for them was removed now. Lucene 3.0 is still able to read indexes with compressed fields, but as soon as merges occur or the index is optimized, all compressed fields are decompressed and converted to Field.Store.YES. Because of this, indexes with compressed fields can suddenly get larger.
{quote}
I think there will be no need for a compression support using reflection.
DIGY.
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-313) SharpZipLib dependency
Posted by "George Aroush (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785313#action_12785313 ]
George Aroush commented on LUCENENET-313:
-----------------------------------------
True, but what about users who have an index created prior to 2.9 and want to migrate to 2.9?
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCENENET-313) SharpZipLib dependency
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12783711#action_12783711 ]
Digy commented on LUCENENET-313:
--------------------------------
We can also remove SupportClass.CompressionSupport and SharpZipLibAdapter.cs since we have Lucene.Net.Documents.CompressionTools now.
DIGY
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
> With the patch, SharpZipLib is not a "must".
> (but no compression support)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCENENET-313) SharpZipLib dependency
Posted by "Digy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENENET-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Digy updated LUCENENET-313:
---------------------------
Attachment: SharpZipLib Dependency.patch
> SharpZipLib dependency
> ----------------------
>
> Key: LUCENENET-313
> URL: https://issues.apache.org/jira/browse/LUCENENET-313
> Project: Lucene.Net
> Issue Type: Improvement
> Reporter: Digy
> Attachments: SharpZipLib Dependency.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.