You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "tju-yxq (via GitHub)" <gi...@apache.org> on 2026/08/12 17:30:12 UTC
[PR] test: cover alert and message query validation [rocketmq-dashboard]
tju-yxq opened a new pull request, #2037:
URL: https://github.com/apache/rocketmq-dashboard/pull/2037
## Summary
This PR adds focused regression coverage for several issue reports whose original descriptions were broader than the repository-verifiable evidence.
It covers current `rocketmq-studio` behavior for:
- alert export replacing non-finite thresholds (`NaN`/`Infinity`) with a finite numeric expression value;
- alert export prefixing alert names that start with a digit so generated rule names start with `[A-Za-z_]`;
- message query rejecting inverted or equal time ranges before broker query calls;
- existing DLQ resend outcome classification tests (`NO_MESSAGES`, `FAILED`, `PARTIAL`);
- existing TPS parsing tests for whitespace handling, 1-minute average selection, and values above the integer range.
## Evidence boundary
- Verified by code inspection and focused/mocked unit tests.
- This PR does not claim live Prometheus validation, live broker/UI testing, or full deployment testing.
## Verification
```bash
cd server
mvn -DskipTests=false "-Dtest=AlertServiceTest#exportPrometheusRulesYamlShouldPrefixAlertNamesStartingWithDigit+exportPrometheusRulesYamlShouldReplaceNonFiniteThresholds,RocketMQMessageProviderTest#queryMessagesShouldRejectInvertedTimeRangeBeforeAdminLookup+queryMessagesShouldRejectEqualTimeRangeBeforeAdminLookup,RocketMQDLQProviderTest#resendMessagesDoesNotPullWhenDlqQueueSetIsNull+resendMessagesCountsNonSendOkResultsAsFailures+resendMessagesMarksAResultPartialWhenOneDlqQueueCannotBeScanned,RocketMQClusterProviderTest#discoverClustersShouldParseRuntimeTpsWithExtraWhitespace+discoverClustersShouldKeepOneMinuteTpsAboveIntegerRange,RocketMQDashboardProviderTest#dashboardShouldKeepPerClusterTpsAboveIntegerRange" test
```
Result: `BUILD SUCCESS`; `Tests run: 10, Failures: 0, Errors: 0, Skipped: 0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover alert and message query validation [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #2037: test: cover alert and message query validation
URL: https://github.com/apache/rocketmq-dashboard/pull/2037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] test: cover alert and message query validation [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #2037:
URL: https://github.com/apache/rocketmq-dashboard/pull/2037#issuecomment-5288760061
Consolidated into #2034 as part of the batch consolidation of @tju-yxq's regression-test PRs (merged into rocketmq-studio). The change is preserved in the merged commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org