You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/18 08:12:13 UTC
[GitHub] [pulsar-client-node] equanz opened a new pull request, #228: Remove node pre gyp
equanz opened a new pull request, #228:
URL: https://github.com/apache/pulsar-client-node/pull/228
### Motivation
From https://github.com/apache/pulsar-client-node/pull/38 , node-pre-gyp was installed as a dependency.
Also, it tries to download a pre-built binary when we install pulsar-client.
However, pre-built binaries are not uploaded yet.
```
npm ERR! node-pre-gyp http GET https://pulsar.apache.org/docs/en/client-libraries-cpp/libpulsar-v1.6.2-node-v83-linux-x64.tar.gz
npm ERR! node-pre-gyp ERR! install response status 404 Not Found on https://pulsar.apache.org/docs/en/client-libraries-cpp/libpulsar-v1.6.2-node-v83-linux-x64.tar.gz
npm ERR! node-pre-gyp WARN Pre-built binaries not installable for pulsar-client@1.6.2 and node@14.17.3 (node-v83 ABI, glibc) (falling back to source compile with node-gyp)
npm ERR! node-pre-gyp WARN Hit error response status 404 Not Found on https://pulsar.apache.org/docs/en/client-libraries-cpp/libpulsar-v1.6.2-node-v83-linux-x64.tar.gz
```
This can lead to confusion like below.
* https://github.com/apache/pulsar-client-node/issues/226
* https://github.com/apache/pulsar-client-node/issues/218
If release managers are not planning to upload pre-built binaries soon, I think we should temporally remove them from this package.
### Modifications
* Remove `@mapbox/node-pre-gyp` dependency and config from package.json
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-client-node] hrsakai merged pull request #228: Remove node-pre-gyp dependency and config
Posted by GitBox <gi...@apache.org>.
hrsakai merged PR #228:
URL: https://github.com/apache/pulsar-client-node/pull/228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org