[jira] [Created] (CB-10654) _platform_add hooks not executed when platform added from repo or directory

["Tony Homer (JIRA)" <ji...@apache.org>]

Tony Homer created CB-10654:
-------------------------------

             Summary: _platform_add hooks not executed when platform added from repo or directory
                 Key: CB-10654
                 URL: https://issues.apache.org/jira/browse/CB-10654
             Project: Apache Cordova
          Issue Type: Bug
          Components: CordovaLib
    Affects Versions: Master
            Reporter: Tony Homer


before_platform_add and after_platform_add hooks are not executed when platforms are added from directory or repo.  This is because the matching logic in platform.js depends on the targets specified in command line arguments.
It seems that the matching logic should be deferred until the platform can be determined via getPlatformDetailsFromDir.
This would require that the before_platform_add hook not be executed until after the platform has been downloaded.

Steps to reproduce
# create a project with hooks for before_platform_add and/or after_platform_add
# add platform from repo or local dir, e.g.
{code}
cordova platform add https://github.com/apache/cordova-android
cordova platform add my-local-copy-of-cordova-android
{code}
# hooks do not get executed



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org