You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/02 22:24:01 UTC
[GitHub] [arrow] houqp opened a new pull request #9080: ARROW-11110: [Rust] [Datafusion] ExecutionContext.table should take immutable reference
houqp opened a new pull request #9080:
URL: https://github.com/apache/arrow/pull/9080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9080: ARROW-11110: [Rust] [Datafusion] ExecutionContext.table should take immutable reference
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9080:
URL: https://github.com/apache/arrow/pull/9080#issuecomment-753538925
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=h1) Report
> Merging [#9080](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=desc) (03f877c) into [master](https://codecov.io/gh/apache/arrow/commit/2e9ff3cbe42c82c755a47eb5cf36fc874e8ec509?el=desc) (2e9ff3c) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9080/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9080 +/- ##
==========================================
- Coverage 82.61% 82.59% -0.02%
==========================================
Files 204 204
Lines 50140 50169 +29
==========================================
+ Hits 41421 41435 +14
- Misses 8719 8734 +15
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/examples/simple\_udaf.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL2V4YW1wbGVzL3NpbXBsZV91ZGFmLnJz) | `0.00% <ø> (ø)` | |
| [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `89.20% <100.00%> (ø)` | |
| [rust/datafusion/src/physical\_plan/hash\_join.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfam9pbi5ycw==) | `86.32% <0.00%> (-3.21%)` | :arrow_down: |
| [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=footer). Last update [43b02de...03f877c](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9080: ARROW-11110: [Rust] [Datafusion] ExecutionContext.table should take immutable reference
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9080:
URL: https://github.com/apache/arrow/pull/9080#issuecomment-753539613
https://issues.apache.org/jira/browse/ARROW-11110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9080: ARROW-11110: [Rust] [Datafusion] ExecutionContext.table should take immutable reference
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9080:
URL: https://github.com/apache/arrow/pull/9080#issuecomment-753538925
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=h1) Report
> Merging [#9080](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=desc) (09abd37) into [master](https://codecov.io/gh/apache/arrow/commit/2e9ff3cbe42c82c755a47eb5cf36fc874e8ec509?el=desc) (2e9ff3c) will **not change** coverage.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9080/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9080 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 204 204
Lines 50140 50140
=======================================
Hits 41421 41421
Misses 8719 8719
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `89.20% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=footer). Last update [43b02de...09abd37](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9080: ARROW-11110: [Rust] [Datafusion] ExecutionContext.table should take immutable reference
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9080:
URL: https://github.com/apache/arrow/pull/9080#issuecomment-753538925
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=h1) Report
> Merging [#9080](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=desc) (2de0f19) into [master](https://codecov.io/gh/apache/arrow/commit/2e9ff3cbe42c82c755a47eb5cf36fc874e8ec509?el=desc) (2e9ff3c) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9080/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9080 +/- ##
==========================================
- Coverage 82.61% 82.59% -0.02%
==========================================
Files 204 204
Lines 50140 50169 +29
==========================================
+ Hits 41421 41436 +15
- Misses 8719 8733 +14
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/execution/context.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9leGVjdXRpb24vY29udGV4dC5ycw==) | `89.20% <100.00%> (ø)` | |
| [rust/datafusion/src/physical\_plan/hash\_join.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2hhc2hfam9pbi5ycw==) | `86.32% <0.00%> (-3.21%)` | :arrow_down: |
| [rust/arrow/src/compute/kernels/take.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvY29tcHV0ZS9rZXJuZWxzL3Rha2UucnM=) | `95.21% <0.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9080/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=footer). Last update [43b02de...03f877c](https://codecov.io/gh/apache/arrow/pull/9080?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao commented on pull request #9080: ARROW-11110: [Rust] [Datafusion] ExecutionContext.table should take immutable reference
Posted by GitBox <gi...@apache.org>.
jorgecarleitao commented on pull request #9080:
URL: https://github.com/apache/arrow/pull/9080#issuecomment-753542800
clippy :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9080: ARROW-11110: [Rust] [Datafusion] ExecutionContext.table should take immutable reference
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9080:
URL: https://github.com/apache/arrow/pull/9080
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org