[GitHub] [incubator-uniffle] xumanbu commented on a diff in pull request #830: [#593][part-1] feat: Codec compress support ByteBuffer

["xumanbu (via GitHub)" <gi...@apache.org>]

xumanbu commented on code in PR #830:
URL: https://github.com/apache/incubator-uniffle/pull/830#discussion_r1172038862


##########
common/src/main/java/org/apache/uniffle/common/compression/SnappyCodec.java:
##########
@@ -64,4 +64,20 @@ public byte[] compress(byte[] src) {
       throw new RssException("Failed to uncompress by Snappy", e);
     }
   }
+
+  @Override
+  public int compress(ByteBuffer src, ByteBuffer dest) {
+    try {
+      int compressedSize = Snappy.compress(src.duplicate(), dest);

Review Comment:
   Snappy is alreay check this limit and throw exception, I think just need comment this limit in SnappyCodec is ok.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org