You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/10/01 14:18:26 UTC
[jira] [Commented] (NIFI-1016) Use centralized priority attribute
name in PriorityAttributePrioritizer
[ https://issues.apache.org/jira/browse/NIFI-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939745#comment-14939745 ]
ASF GitHub Bot commented on NIFI-1016:
--------------------------------------
GitHub user joemeszaros opened a pull request:
https://github.com/apache/nifi/pull/98
NIFI-1016: Use centralized priority attribute name in PriorityAttributePrioritizer
There is a special enum, `CoreAttributes`, containing the core attribute names of a flow file, like `uuid`,`path` and `priority`. This enum is used by tons of other Java classes, and this issue suggests to use `CoreAttributes.PRIORITY` in `PriorityAttributePrioritizer`, instead of a local static String to avoid duplicates and possible misconceptions, or renames.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ImpressTV/nifi NIFI-1016
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit 5086c3f7a36927e4fb7c3838f56c13dc2883126e
Author: Joe <jo...@impresstv.com>
Date: 2015-10-01T12:14:37Z
NIFI-1016: Use centralized priority attribute name in PriorityAttributePrioritizer
----
> Use centralized priority attribute name in PriorityAttributePrioritizer
> -----------------------------------------------------------------------
>
> Key: NIFI-1016
> URL: https://issues.apache.org/jira/browse/NIFI-1016
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Reporter: Joe Mészáros
> Priority: Minor
>
> There is a special enum, {{CoreAttributes}}, containing the core attribute names of a flow file, like {{uuid}},{{path}} and {{priority}}. This enum is used by tons of other Java classes, and this issue suggests to use CoreAttributes.PRIORITY in PriorityAttributePrioritizer, instead of a local static String to avoid duplicates and possible misconceptions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)