[GitHub] [flink] TisonKun edited a comment on issue #9787: [FLINK-14252][coordination] Encapsulate Dispatcher services in DispatcherServices

[GitBox <gi...@apache.org>]

TisonKun edited a comment on issue #9787: [FLINK-14252][coordination] Encapsulate Dispatcher services in DispatcherServices
URL: https://github.com/apache/flink/pull/9787#issuecomment-536291334
 
 
   Thanks for your information @tillrohrmann . If the problem is that `AbstractDispatcherResourceManagerComponentFactory` should not need to know about which `JobManagerRunnerFactory` the `Dispatcher` uses, we could let `DispatcherFactory` takes this responsibility as you do now. Specifically, `DispatcherFactory#createDispatcher` takes all parameters the constructor of `PartialDispatcherServices` takes, in its body it create the completed `DispatcherServices` with an internally known `JobManagerRunnerFactory`. 
   
   `PartialDispatcherServices` is a temporary POJO used in only `AbstractDispatcherResourceManagerComponentFactory` that we directly make a completed one in `DispatcherFactory#createDispatcher`.
   
   Here is a patch based on your branch about the idea above.( https://gist.github.com/TisonKun/2f43982d0b4f5276688149070f88b9c0 )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services