[GitHub] wohali opened a new issue #1455: Re-introduce support for bcrypt

[GitBox <gi...@apache.org>]

wohali opened a new issue #1455: Re-introduce support for bcrypt
URL: https://github.com/apache/couchdb/issues/1455
 
 
   In preparing the 2.2.0 release, it was found that the bcrypt add-on will not compile under Windows. There are at least 2 reasons for this:
   
   1. Windows does not include the BSD libc extensions, meaning there is no `sys/queue.h`.
   1. Our Windows build environment, which does not use msys/mingw/etc, does not have a useful pthread library.
   
   In addition, it seems wrong to me that a NIF to just run an encryption routine is launching its own threads. Threading and scheduling of those threads should be left up to the Erlang interpreter.
   
   Because of the level of integration of bcrypt, it is not feasible to remove the library on one platform, or at configure time. An attempt to do that by @iilyak was aborted, see #1228.
   
   As such, the `bcrypt` application is being removed from master.
   
   ## Expected Behavior
   `bcrypt` functionality should be restored to CouchDB post-2.2.0. That reworked implementation should work under Windows, and should not rely on pthreads.
   
   ## Current Behavior
   Windows build is broken, full stop.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services