You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Ilya Kasnacheev <il...@gmail.com> on 2017/09/12 11:30:32 UTC
Web Sessions not considered valid by our RequestWrapper - FIX
Hello Igniters,
It came to our attention that our handling of Web Sessions is inconsistent:
https://stackoverflow.com/questions/45648884/apache-ignite-spring-secutiry-error
I've filed https://issues.apache.org/jira/browse/IGNITE-6070 and fixed the
issue in https://github.com/apache/ignite/pull/2621 (amended tests pass)
Please step forward to review and possibly merge this change, as I could
not locate any commiters familiar with Web Sessions directly.
Thanks,
--
Ilya Kasnacheev
Re: Web Sessions not considered valid by our RequestWrapper - FIX
Posted by Valentin Kulichenko <va...@gmail.com>.
Ilya,
I'm not suggesting to include this code as-is, but rather add tests that
for this use case and improve code coverage. Our current test seem to be
very artificial and we keep getting issues like this one. I'm open to
suggestions here, this can even be done as a separate task if we extend the
scope.
Adding dependencies in 'test' scope is perfectly acceptable as long as they
are good from licensing standpoint (which is the case for any Spring
artifacts of course).
-Val
On Wed, Sep 13, 2017 at 2:26 AM, Ilya Kasnacheev <il...@gmail.com>
wrote:
> Hello Valentin,
>
> The application you are probably referring to is user code from Stack
> Overflow and its license is uncertain.
>
> Moreover, this will require depending our tests on spring-mvc and
> spring-security.
>
> If that is acceptable, I could throw together a clean room implementation.
> But I still think it tests too little for too much effort. What do you
> think?
>
> Regards,
>
> --
> Ilya Kasnacheev
>
> 2017-09-13 2:33 GMT+03:00 Valentin Kulichenko <
> valentin.kulichenko@gmail.com
> >:
>
> > Ilya,
> >
> > I see you have a fully-pledged application to test the scenario. Is it
> > possible to include it (probably simplified a bit) into our tests suites
> so
> > that it runs periodically? This will not only verify this particular fix,
> > but also prevent us from other issues that may occur.
> >
> > -Val
> >
> > On Tue, Sep 12, 2017 at 9:04 AM, Yakov Zhdanov <yz...@apache.org>
> > wrote:
> >
> > > Val, can you please help?
> > >
> > > --Yakov
> > >
> > > 2017-09-12 14:30 GMT+03:00 Ilya Kasnacheev <ilya.kasnacheev@gmail.com
> >:
> > >
> > > > Hello Igniters,
> > > >
> > > > It came to our attention that our handling of Web Sessions is
> > > inconsistent:
> > > > https://stackoverflow.com/questions/45648884/apache-
> > > > ignite-spring-secutiry-error
> > > >
> > > > I've filed https://issues.apache.org/jira/browse/IGNITE-6070 and
> fixed
> > > the
> > > > issue in https://github.com/apache/ignite/pull/2621 (amended tests
> > pass)
> > > >
> > > > Please step forward to review and possibly merge this change, as I
> > could
> > > > not locate any commiters familiar with Web Sessions directly.
> > > >
> > > > Thanks,
> > > >
> > > > --
> > > > Ilya Kasnacheev
> > > >
> > >
> >
>
Re: Web Sessions not considered valid by our RequestWrapper - FIX
Posted by Ilya Kasnacheev <il...@gmail.com>.
Hello Valentin,
The application you are probably referring to is user code from Stack
Overflow and its license is uncertain.
Moreover, this will require depending our tests on spring-mvc and
spring-security.
If that is acceptable, I could throw together a clean room implementation.
But I still think it tests too little for too much effort. What do you
think?
Regards,
--
Ilya Kasnacheev
2017-09-13 2:33 GMT+03:00 Valentin Kulichenko <valentin.kulichenko@gmail.com
>:
> Ilya,
>
> I see you have a fully-pledged application to test the scenario. Is it
> possible to include it (probably simplified a bit) into our tests suites so
> that it runs periodically? This will not only verify this particular fix,
> but also prevent us from other issues that may occur.
>
> -Val
>
> On Tue, Sep 12, 2017 at 9:04 AM, Yakov Zhdanov <yz...@apache.org>
> wrote:
>
> > Val, can you please help?
> >
> > --Yakov
> >
> > 2017-09-12 14:30 GMT+03:00 Ilya Kasnacheev <il...@gmail.com>:
> >
> > > Hello Igniters,
> > >
> > > It came to our attention that our handling of Web Sessions is
> > inconsistent:
> > > https://stackoverflow.com/questions/45648884/apache-
> > > ignite-spring-secutiry-error
> > >
> > > I've filed https://issues.apache.org/jira/browse/IGNITE-6070 and fixed
> > the
> > > issue in https://github.com/apache/ignite/pull/2621 (amended tests
> pass)
> > >
> > > Please step forward to review and possibly merge this change, as I
> could
> > > not locate any commiters familiar with Web Sessions directly.
> > >
> > > Thanks,
> > >
> > > --
> > > Ilya Kasnacheev
> > >
> >
>
Re: Web Sessions not considered valid by our RequestWrapper - FIX
Posted by Valentin Kulichenko <va...@gmail.com>.
Ilya,
I see you have a fully-pledged application to test the scenario. Is it
possible to include it (probably simplified a bit) into our tests suites so
that it runs periodically? This will not only verify this particular fix,
but also prevent us from other issues that may occur.
-Val
On Tue, Sep 12, 2017 at 9:04 AM, Yakov Zhdanov <yz...@apache.org> wrote:
> Val, can you please help?
>
> --Yakov
>
> 2017-09-12 14:30 GMT+03:00 Ilya Kasnacheev <il...@gmail.com>:
>
> > Hello Igniters,
> >
> > It came to our attention that our handling of Web Sessions is
> inconsistent:
> > https://stackoverflow.com/questions/45648884/apache-
> > ignite-spring-secutiry-error
> >
> > I've filed https://issues.apache.org/jira/browse/IGNITE-6070 and fixed
> the
> > issue in https://github.com/apache/ignite/pull/2621 (amended tests pass)
> >
> > Please step forward to review and possibly merge this change, as I could
> > not locate any commiters familiar with Web Sessions directly.
> >
> > Thanks,
> >
> > --
> > Ilya Kasnacheev
> >
>
Re: Web Sessions not considered valid by our RequestWrapper - FIX
Posted by Yakov Zhdanov <yz...@apache.org>.
Val, can you please help?
--Yakov
2017-09-12 14:30 GMT+03:00 Ilya Kasnacheev <il...@gmail.com>:
> Hello Igniters,
>
> It came to our attention that our handling of Web Sessions is inconsistent:
> https://stackoverflow.com/questions/45648884/apache-
> ignite-spring-secutiry-error
>
> I've filed https://issues.apache.org/jira/browse/IGNITE-6070 and fixed the
> issue in https://github.com/apache/ignite/pull/2621 (amended tests pass)
>
> Please step forward to review and possibly merge this change, as I could
> not locate any commiters familiar with Web Sessions directly.
>
> Thanks,
>
> --
> Ilya Kasnacheev
>