[GitHub] [tvm] comaniac commented on a change in pull request #7964: [NVCC] Bugfix nvcc command tool that relies on the compile time env

[GitBox <gi...@apache.org>]

comaniac commented on a change in pull request #7964:
URL: https://github.com/apache/tvm/pull/7964#discussion_r624752531



##########
File path: python/tvm/contrib/nvcc.py
##########
@@ -89,11 +89,13 @@ def compile_cuda(code, target="ptx", arch=None, options=None, path_target=None):
     cmd += ["-o", file_target]
     cmd += [temp_code]
 
-    cxx_compiler_path = tvm.support.libinfo().get("TVM_CXX_COMPILER_PATH")
-    if cxx_compiler_path != "":
-        # This tells nvcc where to find the c++ compiler just in case it is not in the path.
-        # On Windows it is not in the path by default.
-        cmd += ["-ccbin", cxx_compiler_path]
+    # NOTE: ccbin option can be used to tell nvcc where to find the c++ compiler
+    # just in case it is not in the path. On Windows it is not in the path by default.
+    # However, we cannot we canont use TVM_CXX_COMPILER_PATH because the runtime env.

Review comment:
       ```suggestion
       # However, we cannot use TVM_CXX_COMPILER_PATH because the runtime env.
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org