[jira] [Updated] (GEODE-3641) Correct or remove OplogJUnitTest.testStatsSizeReductionOnRolling

["Patrick Rhomberg (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Rhomberg updated GEODE-3641:
------------------------------------
    Attachment: dead.diff
                inspections.diff

I began a preliminary fix before realizing the task was going to be more complicated than expected.  Find attached two diffs, one to remove the 1.5k+ lines of dead code and one to perform basic inspections and removal of unused members and methods.

`dead.diff` must be applied before `inspections.diff` for the latter to apply cleanly.

> Correct or remove OplogJUnitTest.testStatsSizeReductionOnRolling
> ----------------------------------------------------------------
>
>                 Key: GEODE-3641
>                 URL: https://issues.apache.org/jira/browse/GEODE-3641
>             Project: Geode
>          Issue Type: Bug
>          Components: persistence
>            Reporter: Patrick Rhomberg
>         Attachments: dead.diff, inspections.diff
>
>
> This test has been marked flaky since April of 2016, when the flaky test category was introduced to Geode.
> The test class itself could stand for significant refactoring, including but not limited to:
> * Removal of the 1,500+ lines of commented-out code.
> * Application of Locator and/or Sever Startup Rules in place of extending a base test class.
> * Mock classes and implement semaphore-style synchronization to impose deterministic behavior in tests that currently have potential race conditions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)