You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/05 08:21:30 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #848: Fix #785
JacksonXML support
ppalaga opened a new pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848
Fix #785 JacksonXML support
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388147914
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
As there's no discovery but we deal with a fixed set of ites, maybe we can use strings so we can avoid the the two `Stream.of` and the `Stream.concat`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388170725
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes it is not really related to perf of loading classes but more about about the `complexity` of two nested streams with mapping like looking at the code is seems much more complex that what it actually does but there's no problem to keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #848:
Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388163378
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes, your proposal is valid and I can see the advantages but classes are easier to type in an IDE and any typos will cause a compilation error so it feels safer. I am open to continue discussing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #848: Fix #785
JacksonXML support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#issuecomment-595099049
f45e450 added the missing `<module>jackson-dataformat-xml</module>` in the support parent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388170725
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes it is not really related to perf of loading classes but more about the _perceived complexity_ of two nested streams with mapping. Looking at the code - at least as first look - it seems much more complex that what it actually does but there's no problem to keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388170725
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes it is not really related to perf of loading classes but more about the _perceived complexity_ of two nested streams with mapping. Looking at the code - at first as first look - it seems much more complex that what it actually does but there's no problem to keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388174823
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
Review comment:
I'm always +1 for maintainability you know :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #848: Fix #785
JacksonXML support
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388170725
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes it is not really related to perf of loading classes but more about the _perceived complexity_ of two nested streams with mapping like looking at the code is seems much more complex that what it actually does but there's no problem to keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #848:
Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388163378
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes, your proposal is valid and I can see the advantages but classes are easier to type in an IDE and any typos will cause a compilation error so it feels safer. I am open to discuss this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #848:
Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388192227
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
I am at least hanging this quote from Plato's Timaeus above my table to remind me not to sin against the beauty in the future ;)
> The good, of course, is always beautiful, and the beautiful never lacks proportion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388170725
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes it is not really related to perf of loading classes but more about the _eerceived complexity_ of two nested streams with mapping like looking at the code is seems much more complex that what it actually does but there's no problem to keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388146621
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
Review comment:
maybe we should just use class names as strings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #848:
Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388160619
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
Review comment:
Yeah, we discussed this some time ago with the result that strings are faster and they do not have any disadvantages related to class loading. In the meantime, I asked David about this and he said he finds the perf drawbacks negligible and so I started preferring maintainability. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#848: Fix #785 JacksonXML support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #848: Fix #785 JacksonXML support
URL: https://github.com/apache/camel-quarkus/pull/848#discussion_r388170725
##########
File path: extensions/support/jackson-dataformat-xml/deployment/src/main/java/org/apache/camel/quarkus/support/jackson/datafromat/xml/deployment/JacksonDataformatXmlSupportProcessor.java
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.support.jackson.datafromat.xml.deployment;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.Set;
+import java.util.stream.Stream;
+
+import javax.xml.stream.XMLEventFactory;
+import javax.xml.stream.XMLInputFactory;
+import javax.xml.stream.XMLOutputFactory;
+
+import com.ctc.wstx.shaded.msv.org_isorelax.verifier.VerifierFactoryLoader;
+import com.ctc.wstx.shaded.msv.relaxng_datatype.DatatypeLibraryFactory;
+import com.fasterxml.jackson.core.JsonFactory;
+import com.fasterxml.jackson.core.ObjectCodec;
+import io.quarkus.deployment.annotations.BuildProducer;
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.builditem.DeploymentClassLoaderBuildItem;
+import io.quarkus.deployment.builditem.FeatureBuildItem;
+import io.quarkus.deployment.builditem.nativeimage.ServiceProviderBuildItem;
+import io.quarkus.deployment.util.ServiceUtil;
+import org.codehaus.stax2.validation.XMLValidationSchemaFactory;
+
+public class JacksonDataformatXmlSupportProcessor {
+
+ private static final String FEATURE = "camel-support-jackson-dataformat-xml";
+ static final String SERVICES_PREFIX = "META-INF/services/";
+
+ @BuildStep
+ FeatureBuildItem feature() {
+ return new FeatureBuildItem(FEATURE);
+ }
+
+ @BuildStep
+ void serviceProviders(BuildProducer<ServiceProviderBuildItem> serviceProviders,
+ final DeploymentClassLoaderBuildItem classLoader) {
+ Stream.concat(
+ Stream.of(
+ JsonFactory.class,
+ ObjectCodec.class,
+ VerifierFactoryLoader.class,
+ DatatypeLibraryFactory.class,
+ XMLEventFactory.class,
+ XMLInputFactory.class,
+ XMLOutputFactory.class)
+ .map(Class::getName),
+ Stream.of(
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_DTD,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_RELAXNG,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_W3C,
+ XMLValidationSchemaFactory.INTERNAL_ID_SCHEMA_TREX)
+ .map(schemaId -> XMLValidationSchemaFactory.class.getName() + "." + schemaId))
Review comment:
Yes it is not really related to perf of loading classes but more about the p_erceived complexity_ of two nested streams with mapping like looking at the code is seems much more complex that what it actually does but there's no problem to keep it as it is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services