You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/02/21 11:35:25 UTC
[GitHub] [skywalking] arugal opened a new pull request #4395: [test/plugin]
immigrate h2 & struts scenario
arugal opened a new pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
#3583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-589631735
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=h1) Report
> Merging [#4395](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/241abf840cb9ccc512145d3695611a01eee9af0d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4395 +/- ##
==========================================
+ Coverage 25.55% 25.55% +<.01%
==========================================
Files 1209 1209
Lines 27914 27914
Branches 3851 3851
==========================================
+ Hits 7133 7134 +1
Misses 20129 20129
+ Partials 652 651 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `60% <0%> (+1.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=footer). Last update [241abf8...c3c5d05](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-589631735
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=h1) Report
> Merging [#4395](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/7315f75c7c1bc67df6fc6dab88bb19a69805f8cb?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4395 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 1209 1209
Lines 27914 27914
Branches 3851 3851
=======================================
Hits 7134 7134
Misses 20129 20129
Partials 651 651
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=footer). Last update [7315f75...5095780](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#discussion_r382646477
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -53,7 +53,7 @@ jobs:
- name: Run okhttp 3.0.x-3.14.x (34)
run: bash test/plugin/run.sh okhttp-scenario
- Spring31x_ES5_Gateway_Avro:
+ Spring31x_ES5_Gateway_Avro_Struts2.5:
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-589631735
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=h1) Report
> Merging [#4395](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/241abf840cb9ccc512145d3695611a01eee9af0d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4395 +/- ##
==========================================
+ Coverage 25.55% 25.56% +<.01%
==========================================
Files 1209 1209
Lines 27914 27914
Branches 3851 3851
==========================================
+ Hits 7133 7135 +2
+ Misses 20129 20128 -1
+ Partials 652 651 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `69.23% <0%> (+1.28%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `60% <0%> (+1.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=footer). Last update [241abf8...9e2c737](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#discussion_r382883999
##########
File path: test/plugin/scenarios/struts2.5-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {struts2.5-scenario: 2}
+ instances:
+ - {struts2.5-scenario: 1}
+ operationNames:
+ - struts2.5-scenario: [/struts2.5-scenario/struts-scenario/case.action]
+ heartbeat: []
+segmentItems:
+ - applicationCode: struts2.5-scenario
+ segmentSize: gt 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /struts2.5-scenario/struts-scenario/case.action
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: gt 0
+ endTime: gt 0
+ componentId: 15
+ componentName: ''
+ isError: false
+ spanType: Entry
Review comment:
I prefer to enhance this case, we should check the ref by adding a http call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-589631735
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=h1) Report
> Merging [#4395](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/241abf840cb9ccc512145d3695611a01eee9af0d?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4395 +/- ##
=======================================
Coverage 25.55% 25.55%
=======================================
Files 1209 1209
Lines 27914 27914
Branches 3851 3851
=======================================
Hits 7133 7133
Misses 20129 20129
Partials 652 652
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=footer). Last update [241abf8...7315f75](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4395: [test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#discussion_r382577242
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -333,7 +335,7 @@ jobs:
- name: Run zookeeper 3.4.x (14)
run: bash test/plugin/run.sh zookeeper-scenario
- Spring43:
+ Spring43_Struts2.3:
Review comment:
Ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal commented on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-590049520
@wu-sheng @dmsolr The test has passed, please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal opened a new pull request #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal opened a new pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395
Please answer these questions before submitting pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related issues
#3583
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-590019859
@arugal You could rerun from the `Checks` tab.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-589631735
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=h1) Report
> Merging [#4395](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/67b7f22a4074a8d714b603cb27400fdcb9ec31f4?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4395 +/- ##
=========================================
- Coverage 25.65% 25.55% -0.1%
=========================================
Files 1209 1209
Lines 27914 27914
Branches 3851 3851
=========================================
- Hits 7160 7134 -26
- Misses 20103 20129 +26
Partials 651 651
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `41.17% <0%> (-41.18%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `60% <0%> (-20%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `66.66% <0%> (-18.52%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `78.08% <0%> (-1.37%)` | :arrow_down: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `67.94% <0%> (-1.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=footer). Last update [67b7f22...5d7a924](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-589631735
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=h1) Report
> Merging [#4395](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/241abf840cb9ccc512145d3695611a01eee9af0d?src=pr&el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4395 +/- ##
=========================================
- Coverage 25.65% 25.55% -0.1%
=========================================
Files 1209 1209
Lines 27914 27914
Branches 3851 3851
=========================================
- Hits 7160 7134 -26
- Misses 20103 20129 +26
Partials 651 651
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...apm/agent/core/remote/GRPCStreamServiceStatus.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENTdHJlYW1TZXJ2aWNlU3RhdHVzLmphdmE=) | `41.17% <0%> (-41.18%)` | :arrow_down: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `60% <0%> (-20%)` | :arrow_down: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `66.66% <0%> (-18.52%)` | :arrow_down: |
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `78.08% <0%> (-1.37%)` | :arrow_down: |
| [...king/apm/agent/core/remote/GRPCChannelManager.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsTWFuYWdlci5qYXZh) | `67.94% <0%> (-1.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=footer). Last update [241abf8...7315f75](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal commented on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-590020490
> @arugal could you fix the component id in https://github.com/apache/skywalking/blob/master/test/plugin/scenarios/undertow-scenario/config/expectedData.yaml , the component id of Undertow is changed to 84 in #4398 and it will fail then
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#discussion_r382924028
##########
File path: test/plugin/scenarios/struts2.5-scenario/config/expectedData.yaml
##########
@@ -0,0 +1,49 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+registryItems:
+ applications:
+ - {struts2.5-scenario: 2}
+ instances:
+ - {struts2.5-scenario: 1}
+ operationNames:
+ - struts2.5-scenario: [/struts2.5-scenario/struts-scenario/case.action]
+ heartbeat: []
+segmentItems:
+ - applicationCode: struts2.5-scenario
+ segmentSize: gt 1
+ segments:
+ - segmentId: not null
+ spans:
+ - operationName: /struts2.5-scenario/struts-scenario/case.action
+ operationId: 0
+ parentSpanId: -1
+ spanId: 0
+ spanLayer: Http
+ startTime: gt 0
+ endTime: gt 0
+ componentId: 15
+ componentName: ''
+ isError: false
+ spanType: Entry
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-590020233
@arugal could you fix the component id in https://github.com/apache/skywalking/blob/master/test/plugin/scenarios/undertow-scenario/config/expectedData.yaml , the component id of Undertow is changed to 84 in #4398 and it will fail then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on issue #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal commented on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-590019938
> @arugal You could rerun from the `Checks` tab.
Rerun still failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal commented on a change in pull request #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal commented on a change in pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#discussion_r382646535
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -333,7 +335,7 @@ jobs:
- name: Run zookeeper 3.4.x (14)
run: bash test/plugin/run.sh zookeeper-scenario
- Spring43:
+ Spring43_Struts2.3:
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-589631735
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=h1) Report
> Merging [#4395](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/241abf840cb9ccc512145d3695611a01eee9af0d?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4395 +/- ##
==========================================
+ Coverage 25.55% 25.55% +<.01%
==========================================
Files 1209 1209
Lines 27914 27914
Branches 3851 3851
==========================================
+ Hits 7133 7134 +1
Misses 20129 20129
+ Partials 652 651 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../apm/network/trace/component/ComponentsDefine.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXByb3RvY29sL2FwbS1uZXR3b3JrL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9uZXR3b3JrL3RyYWNlL2NvbXBvbmVudC9Db21wb25lbnRzRGVmaW5lLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4395/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `60% <0%> (+1.66%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=footer). Last update [241abf8...3c2163b](https://codecov.io/gh/apache/skywalking/pull/4395?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4395: [test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#discussion_r382576680
##########
File path: .github/workflows/plugins-test.yaml
##########
@@ -53,7 +53,7 @@ jobs:
- name: Run okhttp 3.0.x-3.14.x (34)
run: bash test/plugin/run.sh okhttp-scenario
- Spring31x_ES5_Gateway_Avro:
+ Spring31x_ES5_Gateway_Avro_Struts2.5:
Review comment:
`.` is not valid as a yaml section name, unless it’s quoted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 edited a comment on issue #4395:
[test/plugin] immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 edited a comment on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-590020233
@arugal could you fix the component id in https://github.com/apache/skywalking/blob/master/test/plugin/scenarios/undertow-scenario/config/expectedData.yaml in this pull request too, the component id of Undertow is changed to 84 in #4398 and it will fail then
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395#issuecomment-590019087
Strange. Look like checkout failure?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] arugal closed pull request #4395: [test/plugin]
immigrate h2 & struts scenario
Posted by GitBox <gi...@apache.org>.
arugal closed pull request #4395: [test/plugin] immigrate h2 & struts scenario
URL: https://github.com/apache/skywalking/pull/4395
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services