You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/01 19:58:05 UTC
Re: Review Request 66051: Implemented operator API to grow and shrink
persistent volume.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66051/#review202209
-----------------------------------------------------------
Fix it, then Ship it!
src/master/http.cpp
Lines 1557 (patched)
<https://reviews.apache.org/r/66051/#comment283960>
The `volume` and `addition` fields contain
src/master/http.cpp
Lines 1625 (patched)
<https://reviews.apache.org/r/66051/#comment283961>
Suggestion: The `volume` field contains the resource required for this operation.
- Chun-Hung Hsiao
On April 27, 2018, 8:09 p.m., Zhitao Li wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66051/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 8:09 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-8747
> https://issues.apache.org/jira/browse/MESOS-8747
>
>
> Repository: mesos
>
>
> Description
> -------
>
> These operator APIs is implemented as speculative for now, but
> we plan to convert them to non-speculative in the future.
>
>
> Diffs
> -----
>
> src/master/http.cpp 135ae4389623385a6638158f5f23d6daca14a0ad
> src/master/master.hpp a7cadd9c97add92a0276bf64e0da941cae63fd7c
> src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d
>
>
> Diff: https://reviews.apache.org/r/66051/diff/15/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zhitao Li
>
>