You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <re...@gmail.com> on 2013/07/05 23:03:01 UTC

Review Request 12287: Correct path to '/frameworks/:id'

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12287/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

'/framework/:id' (singular) is not a valid path.


Diffs
-----

  src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 

Diff: https://reviews.apache.org/r/12287/diff/


Testing
-------


Thanks,

Ross Allen


Re: Review Request 12287: Correct path to '/frameworks/:id'

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12287/#review22848
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On July 5, 2013, 11:01 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12287/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 11:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> '/framework/:id' (singular) is not a valid path.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 
> 
> Diff: https://reviews.apache.org/r/12287/diff/
> 
> 
> Testing
> -------
> 
> Clicked link to confirm navigation led to a real route. Before the change it returned an error.
> 
> 
> Thanks,
> 
> Ross Allen
> 
>


Re: Review Request 12287: Correct path to '/frameworks/:id'

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12287/#review22828
-----------------------------------------------------------

Ship it!


Yes!

- Benjamin Hindman


On July 5, 2013, 11:01 p.m., Ross Allen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12287/
> -----------------------------------------------------------
> 
> (Updated July 5, 2013, 11:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> '/framework/:id' (singular) is not a valid path.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 
> 
> Diff: https://reviews.apache.org/r/12287/diff/
> 
> 
> Testing
> -------
> 
> Clicked link to confirm navigation led to a real route. Before the change it returned an error.
> 
> 
> Thanks,
> 
> Ross Allen
> 
>


Re: Review Request 12287: Correct path to '/frameworks/:id'

Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12287/
-----------------------------------------------------------

(Updated July 5, 2013, 11:01 p.m.)


Review request for mesos.


Repository: mesos


Description
-------

'/framework/:id' (singular) is not a valid path.


Diffs
-----

  src/webui/master/static/home.html 0074f318e87070fd2f5004f23a4d80d04a7047d1 

Diff: https://reviews.apache.org/r/12287/diff/


Testing (updated)
-------

Clicked link to confirm navigation led to a real route. Before the change it returned an error.


Thanks,

Ross Allen