You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Sidharth Mishra <si...@gmail.com> on 2020/12/15 17:45:14 UTC
Review Request 73089: ATLAS-408: Atlas incorrectly reports successful
change to glossary term
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73089/
-----------------------------------------------------------
Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, Radhika Kundam, and Sarath Subramanian.
Bugs: ATLAS-4081
https://issues.apache.org/jira/browse/ATLAS-4081
Repository: atlas
Description
-------
ATLAS-4081: Atlas incorrectly reports successful change to glossary term
Diffs
-----
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java d630f669e
Diff: https://reviews.apache.org/r/73089/diff/1/
Testing
-------
Created one more user - sid which is not an admin user and reproduced the issue. Then patched the cluster with the fix and confirmed it works. Now the behaviour is same as GlossaryService.
Thanks,
Sidharth Mishra
Re: Review Request 73089: ATLAS-408: Atlas incorrectly reports
successful change to glossary term
Posted by Deep Singh <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73089/#review222348
-----------------------------------------------------------
Ship it!
Ship It!
- Deep Singh
On Dec. 15, 2020, 5:45 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73089/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2020, 5:45 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4081
> https://issues.apache.org/jira/browse/ATLAS-4081
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4081: Atlas incorrectly reports successful change to glossary term
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java d630f669e
>
>
> Diff: https://reviews.apache.org/r/73089/diff/1/
>
>
> Testing
> -------
>
> Created one more user - sid which is not an admin user and reproduced the issue. Then patched the cluster with the fix and confirmed it works. Now the behaviour is same as GlossaryService.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73089: ATLAS-408: Atlas incorrectly reports
successful change to glossary term
Posted by Sidharth Mishra <si...@gmail.com>.
> On Dec. 15, 2020, 6:54 p.m., Deep Singh wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Line 416 (original), 415 (patched)
> > <https://reviews.apache.org/r/73089/diff/1/?file=2243547#file2243547line416>
> >
> > What Exception is thrown here? Does it throw unauthorized error. And in such cases, does the API sends 401 response ?
{"errorCode":"ATLAS-403-00-001","errorMessage":"sid is not authorized to perform update entity: type=AtlasGlossaryTerm"} is been thrown and Status Code: 403 Forbidden
- Sidharth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73089/#review222345
-----------------------------------------------------------
On Dec. 15, 2020, 5:45 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73089/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2020, 5:45 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4081
> https://issues.apache.org/jira/browse/ATLAS-4081
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4081: Atlas incorrectly reports successful change to glossary term
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java d630f669e
>
>
> Diff: https://reviews.apache.org/r/73089/diff/1/
>
>
> Testing
> -------
>
> Created one more user - sid which is not an admin user and reproduced the issue. Then patched the cluster with the fix and confirmed it works. Now the behaviour is same as GlossaryService.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73089: ATLAS-408: Atlas incorrectly reports
successful change to glossary term
Posted by Deep Singh <de...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73089/#review222345
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Line 416 (original), 415 (patched)
<https://reviews.apache.org/r/73089/#comment311409>
What Exception is thrown here? Does it throw unauthorized error. And in such cases, does the API sends 401 response ?
- Deep Singh
On Dec. 15, 2020, 5:45 p.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73089/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2020, 5:45 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4081
> https://issues.apache.org/jira/browse/ATLAS-4081
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4081: Atlas incorrectly reports successful change to glossary term
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java d630f669e
>
>
> Diff: https://reviews.apache.org/r/73089/diff/1/
>
>
> Testing
> -------
>
> Created one more user - sid which is not an admin user and reproduced the issue. Then patched the cluster with the fix and confirmed it works. Now the behaviour is same as GlossaryService.
>
>
> Thanks,
>
> Sidharth Mishra
>
>
Re: Review Request 73089: ATLAS-408: Atlas incorrectly reports
successful change to glossary term
Posted by Sarath Subramanian <sa...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73089/#review222351
-----------------------------------------------------------
Ship it!
Ship It!
- Sarath Subramanian
On Dec. 15, 2020, 9:45 a.m., Sidharth Mishra wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73089/
> -----------------------------------------------------------
>
> (Updated Dec. 15, 2020, 9:45 a.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, Radhika Kundam, and Sarath Subramanian.
>
>
> Bugs: ATLAS-4081
> https://issues.apache.org/jira/browse/ATLAS-4081
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-4081: Atlas incorrectly reports successful change to glossary term
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java d630f669e
>
>
> Diff: https://reviews.apache.org/r/73089/diff/1/
>
>
> Testing
> -------
>
> Created one more user - sid which is not an admin user and reproduced the issue. Then patched the cluster with the fix and confirmed it works. Now the behaviour is same as GlossaryService.
>
>
> Thanks,
>
> Sidharth Mishra
>
>