You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/08/06 14:05:58 UTC
[Impala-ASF-CR] IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14019
Change subject: IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
......................................................................
IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
After raising the maximum bit width for bit packing to 64 bits,
DictDecoder accepted bit widths between 32 and 64, but internally it
uses 32 bit integers and unpacking ran into a DCHECK.
Adding a check to DictDecoder to catch if the bit width is higher than
32.
Testing:
Added a test that asserts that DictDecoder accepts bit widths 0-32
and rejects higher bit widths which could still be unpacked
otherwise.
Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
---
M be/src/util/dict-encoding.h
M be/src/util/dict-test.cc
2 files changed, 31 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14019/2
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4153/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 15:05:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
After raising the maximum bit width for bit packing to 64 bits,
DictDecoder accepted bit widths between 32 and 64, but internally it
uses 32 bit integers and unpacking ran into a DCHECK.
Adding a check to DictDecoder to catch if the bit width is higher than
32.
Testing:
Added a test that asserts that DictDecoder accepts bit widths 0-32
and rejects higher bit widths which could still be unpacked
otherwise.
Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
---
M be/src/util/dict-encoding.h
M be/src/util/dict-test.cc
2 files changed, 31 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14019/4
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14019/2/be/src/util/dict-encoding.h
File be/src/util/dict-encoding.h:
http://gerrit.cloudera.org:8080/#/c/14019/2/be/src/util/dict-encoding.h@256
PS2, Line 256: CHAR_BIT
nit: I would prefer simply 8
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 14:15:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4151/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 14:47:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
After raising the maximum bit width for bit packing to 64 bits,
DictDecoder accepted bit widths between 32 and 64, but internally it
uses 32 bit integers and unpacking ran into a DCHECK.
Adding a check to DictDecoder to catch if the bit width is higher than
32.
Testing:
Added a test that asserts that DictDecoder accepts bit widths 0-32
and rejects higher bit widths which could still be unpacked
otherwise.
Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Reviewed-on: http://gerrit.cloudera.org:8080/14019
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
---
M be/src/util/dict-encoding.h
M be/src/util/dict-test.cc
2 files changed, 31 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4743/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 20:48:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
......................................................................
IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
After raising the maximum bit width for bit packing to 64 bits,
DictDecoder accepted bit widths between 32 and 64, but internally it
uses 32 bit integers and unpacking ran into a DCHECK.
Adding a check to DictDecoder to catch if the bit width is higher than
32.
Testing:
Added a test that asserts that DictDecoder accepts bit widths 0-32
and rejects higher bit widths which could still be unpacked
otherwise.
Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
---
M be/src/util/dict-encoding.h
M be/src/util/dict-test.cc
2 files changed, 31 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/14019/3
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 03:38:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 01:44:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4739/
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 19:43:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 4:
(1 comment)
Looks good, just had one nit about the test
http://gerrit.cloudera.org:8080/#/c/14019/4/be/src/util/dict-test.cc
File be/src/util/dict-test.cc:
http://gerrit.cloudera.org:8080/#/c/14019/4/be/src/util/dict-test.cc@287
PS4, Line 287: EXPECT_TRUE(status.ok());
We have an EXPECT_OK macro for this that will print the error if the check fails.
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 16:39:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833 - Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14019/2/be/src/util/dict-encoding.h
File be/src/util/dict-encoding.h:
http://gerrit.cloudera.org:8080/#/c/14019/2/be/src/util/dict-encoding.h@256
PS2, Line 256: 8
> nit: I would prefer simply 8
Done.
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 14:29:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4152/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 15:09:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14019 )
Change subject: IMPALA-8833: Check failed in BatchedBitReader::UnpackBatch()
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4739/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4cba3338a93f8287c24abbe3ad9bfcbfa756bca4
Gerrit-Change-Number: 14019
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 14:51:09 +0000
Gerrit-HasComments: No