You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/03/11 21:57:00 UTC

[jira] [Commented] (GEODE-7867) Add more unit tests to geode-tcp-server

    [ https://issues.apache.org/jira/browse/GEODE-7867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17057436#comment-17057436 ] 

ASF subversion and git services commented on GEODE-7867:
--------------------------------------------------------

Commit 3746afcb623e6072211591be35f69834c3ed1a63 in geode's branch refs/heads/feature/GEODE-7867 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3746afc ]

GEODE-7867 Add more unit tests to geode-tcp-server

Cleaned up a distributedTest that no longer needs to reference
geode-core 7 moved it to the unit test source set.

Added additional tests.


> Add more unit tests to geode-tcp-server
> ---------------------------------------
>
>                 Key: GEODE-7867
>                 URL: https://issues.apache.org/jira/browse/GEODE-7867
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Bruce J Schuchardt
>            Assignee: Bruce J Schuchardt
>            Priority: Major
>
> This new module has few tests and relies mostly on geode-core and other modules to test its functionality.
> HostAndPort has tests for only 5 of its 14 methods.
> ClientSocketCreatorImpl is untested
> TcpClient has only 50% code coverage.
> TcpServer's run() method has error handling that is untested.
> I counted tests from geode-membership when running this analysis.  If you leave out that module the numbers are even worse.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)