You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/17 03:24:20 UTC
[GitHub] [spark] beliefer commented on a diff in pull request #39091: [SPARK-41527][CONNECT][PYTHON] Implement DataFrame.observe
beliefer commented on code in PR #39091:
URL: https://github.com/apache/spark/pull/39091#discussion_r1051302541
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -126,6 +126,20 @@ package object dsl {
Expression.UnresolvedFunction.newBuilder().setFunctionName("min").addArguments(e))
.build()
+ def proto_max(e: Expression): Expression =
Review Comment:
I just follows up the existing `proto_min`.
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -126,6 +126,20 @@ package object dsl {
Expression.UnresolvedFunction.newBuilder().setFunctionName("min").addArguments(e))
.build()
+ def proto_max(e: Expression): Expression =
Review Comment:
I just follow up the existing `proto_min`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org