You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/02/15 10:22:06 UTC

[GitHub] incubator-zeppelin pull request: [DOCS][JDBC]Guide user to add jdb...

GitHub user minahlee opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/717

    [DOCS][JDBC]Guide user to add jdbc driver jar file via GUI interpreter menu

    ### What is this PR for?
    Update jdbc documentation to let user load dependencies via GUI interpreter menu instead of editing `zeppelin-daemon.sh`
    
    ### What type of PR is it?
    Documentation
    
    ### Is there a relevant Jira issue?
    No
    
    ### Screenshots (if appropriate)
    **Before**
    ![screen shot 2016-02-15 at 6 20 55 pm](https://cloud.githubusercontent.com/assets/8503346/13044330/eaee3142-d410-11e5-9a48-2d57c36360d5.png)
    ![screen shot 2016-02-15 at 6 21 04 pm](https://cloud.githubusercontent.com/assets/8503346/13044331/ec70a144-d410-11e5-99b3-90f253d1a37a.png)
    
    
    **After**
    
    ![screen shot 2016-02-15 at 6 19 51 pm](https://cloud.githubusercontent.com/assets/8503346/13044300/c8f9a8f0-d410-11e5-8ba9-4cfc5bd95cf3.png)
    ![screen shot 2016-02-15 at 6 20 04 pm](https://cloud.githubusercontent.com/assets/8503346/13044304/ca4d44be-d410-11e5-9b7b-a09119970b51.png)
    
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/minahlee/incubator-zeppelin update/jdbcDoc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/717.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #717
    
----
commit 4b73365078e80d14663667f2daa17d78a185911d
Author: Mina Lee <mi...@nflabs.com>
Date:   2016-02-15T09:11:01Z

    * Guide user to use dependencies to add jdbc driver instead of editing `zeppelin-daemeon.sh` file
    * Fix some grammar

commit 38ef52aa935f8bd456799e5e518af97a630d33b6
Author: Mina Lee <mi...@nflabs.com>
Date:   2016-02-15T09:13:04Z

    Add image files

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [DOCS][JDBC] Guide user to add jd...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/717


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [DOCS][JDBC] Guide user to add jd...

Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/717#issuecomment-184509262
  
    It looks fantastic!! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [DOCS][JDBC] Guide user to add jd...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/717#issuecomment-186431062
  
    LGTM and merge if there're no more discussions


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---