[GitHub] [roller] snoopdave opened a new pull request #83: Remove provided scope for JSTL

[GitBox <gi...@apache.org>]

snoopdave opened a new pull request #83:
URL: https://github.com/apache/roller/pull/83


   This PR removes provided scope for JSTL becuase JSTL is not provided by Tomcat. I erroneously added provided scope a couple months ago when I was trying to get the Maven Jetty stuff working.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [roller] snoopdave merged pull request #83: Remove provided scope for JSTL

[GitBox <gi...@apache.org>]

snoopdave merged pull request #83:
URL: https://github.com/apache/roller/pull/83


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [roller] mbien commented on pull request #83: Remove provided scope for JSTL

[GitBox <gi...@apache.org>]

mbien commented on pull request #83:
URL: https://github.com/apache/roller/pull/83#issuecomment-821809146


   if i remember correctly JSTL libs are supposed to be placed in the classpath of the server/container, not the application. However, these days this should not make any difference anymore since there is usually only one app per server instance - so not much can go wrong.
   
   Keeping it in the roller war for convenience reasons is probably fine - i don't think anyone complained so far :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org