You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by du...@v.igoro.us on 2007/05/10 08:05:30 UTC

[PATCH] 1/5 svnmerge: clearly differentiate urls, directories, and repo-relative paths

This is the first of five patches, the last of which implements
cross-repository merging even when repo-relative paths are identical

This patch is fairly trivial.  I'll send the next one when the
disposition of this is decided.

[[[
clearly differentiate urls, directories, and repo-relative paths

* svn/trunk/contrib/client-side/svnmerge/svnmerge.py: fix comments,
 variable names for urls, directories, and 
 "repostitory-relative paths" to be more explicit and call the 
 repo-relative paths "location identifiers"
]]]

Dustin

Re: [PATCH] 1/5 svnmerge: clearly differentiate urls, directories, and repo-relative paths

Posted by David James <ja...@cs.toronto.edu>.
On 5/11/07, dustin@v.igoro.us <du...@v.igoro.us> wrote:
> On Thu, May 10, 2007 at 03:05:30AM -0500, dustin@v.igoro.us wrote:
> > This is the first of five patches, the last of which implements
> > cross-repository merging even when repo-relative paths are identical
>
> Any feedback on this?  I realize it's basically changing comments, but
> the good stuff is in parts 2-5 ;)

Hi Dustin,

Personally, I'm not a big fan of the term "locid", but other than
that, your patch looks great. How about "path_id"? In the comments, we
can explain that a path_id is a UUID/path pair. Further, in
user-facing error messages where we talk about path_ids, we should
probably call them UUID/path pairs, so that users will understand what
we are talking about without needing to read the source.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] 1/5 svnmerge: clearly differentiate urls, directories, and repo-relative paths

Posted by du...@v.igoro.us.
On Thu, May 10, 2007 at 03:05:30AM -0500, dustin@v.igoro.us wrote:
> This is the first of five patches, the last of which implements
> cross-repository merging even when repo-relative paths are identical

Any feedback on this?  I realize it's basically changing comments, but
the good stuff is in parts 2-5 ;)

Dustin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org