You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Daniel Dai (JIRA)" <ji...@apache.org> on 2009/10/22 19:10:59 UTC
[jira] Created: (PIG-1041) javac warnings: cast, fallthrough,
serial
javac warnings: cast, fallthrough, serial
-----------------------------------------
Key: PIG-1041
URL: https://issues.apache.org/jira/browse/PIG-1041
Project: Pig
Issue Type: Bug
Affects Versions: 0.4.0
Reporter: Daniel Dai
Assignee: Daniel Dai
Fix For: 0.6.0
Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
cast (49)
fallthrough (1)
serial (19)
The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1041:
----------------------------
Attachment: PIG-1041-1.patch
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769026#action_12769026 ]
Hadoop QA commented on PIG-1041:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12422919/PIG-1041-1.patch
against trunk revision 828773.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/110/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/110/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Pig-Patch-h7.grid.sp2.yahoo.net/110/console
This message is automatically generated.
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1041-1.patch
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1041:
----------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Patch committed. Move javacc related warnings to PIG-1049.
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1041-1.patch
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768771#action_12768771 ]
Daniel Dai commented on PIG-1041:
---------------------------------
The plan is:
1. Suppressing warnings in the code level as much as possible
2. Some "cast" warnings are from the generated code of javacc, which is out of our control. As a result, we will suppress all "cast" warnings in build.xml.
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1041:
----------------------------
Attachment: PIG-1041-1.patch
Attached patch address target javac warnings in the code level. Still couple of warnings from javacc which is out of our control, we will suppress it in build.xml. The change of build.xml will be included in PIG-1033.
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1041-1.patch
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769383#action_12769383 ]
Olga Natkovich commented on PIG-1041:
-------------------------------------
+1 on the patch. In general, I believe there is a way to supress warnings at the package level.
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1041-1.patch
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1041:
----------------------------
Attachment: PIG-1041-1.patch
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1041-1.patch
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1041:
----------------------------
Status: Patch Available (was: Open)
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
> Attachments: PIG-1041-1.patch
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1041) javac warnings: cast, fallthrough,
serial
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1041:
----------------------------
Attachment: (was: PIG-1041-1.patch)
> javac warnings: cast, fallthrough, serial
> -----------------------------------------
>
> Key: PIG-1041
> URL: https://issues.apache.org/jira/browse/PIG-1041
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Daniel Dai
> Assignee: Daniel Dai
> Fix For: 0.6.0
>
>
> Pig have javac warnings when you build it with the option "-Dall.warnings=1". We need to suppress all of them. This issue is to track the javac warnings in the following categories:
> cast (49)
> fallthrough (1)
> serial (19)
> The number in the parenthesis is the times of occurrence of particular javac warning.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.