You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/04 18:13:51 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #9097: [WIP] Schema and CRUD endpoints Pool

mik-laj commented on a change in pull request #9097:
URL: https://github.com/apache/airflow/pull/9097#discussion_r435453557



##########
File path: airflow/api_connexion/exceptions.py
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+
+def response_404(

Review comment:
       I think, we should use exception to handle errors. 
   I have prepared an example that shows how to do it.
   https://termbin.com/legq
   To add this commit to your brach, run the following command:
   ```
   curl https://termbin.com/legq | git am
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org