You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by hustfxj <gi...@git.apache.org> on 2017/03/28 09:24:30 UTC
[GitHub] incubator-rocketmq-externals pull request #5: [ROCKETMQ-81] import rocketmq ...
GitHub user hustfxj opened a pull request:
https://github.com/apache/incubator-rocketmq-externals/pull/5
[ROCKETMQ-81] import rocketmq plugin for spark streaming
This plugin is for spark streaming based on pull mode. And you can see READ.ME for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hustfxj/incubator-rocketmq-externals master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq-externals/pull/5.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5
----
commit 4744f720d9ae6ad3373aba631187a958ad57a7a2
Author: xiaojian.fxj <xi...@alibaba-inc.com>
Date: 2017-03-28T09:20:45Z
[ROCKETMQ-81] import rocketmq plugin for spark streaming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@vesense How much the merge progress has been made now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@vesense It's great! thank you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
I have completed the merging. The PR after merged is here: https://github.com/apache/incubator-rocketmq-externals/pull/4. Now I think we can merge it initially.
The following is the change:
* merge PR #5 to #4
* fix the jdk version to 1.8
* fix package path
* merge common configs to java/org.apache.rocketmq.spark.RocketMQConfig
* merge common utils to scala/org.apache.rocketmq.spark.RocketMqUtils
* add RocketMQServerMock to improve testing
* improve document
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
rocketmq-docker has been added as an external project
Posted by dongeforever <10...@qq.com>.
Hi Guys:
rocketmq-docker has been added as an external project in :
https://github.com/apache/incubator-rocketmq-externals
Although I have tested in my local docker environment on Mac OSX, the docker file and scripts are only drafted ones, much work need to be done and any polishing is welcome.
Regards
dongeforever
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by ranqiqiang <gi...@git.apache.org>.
Github user ranqiqiang commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
\u611f\u8c22 ~\u3002~ \u8fd9\u4e2a\u4e1c\u897f \u80fd\u6b63\u5f0f\u4f7f\u7528\u4e86\u5417\uff1f \u671f\u5f85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@zhouxinyu yes, luckily they are :)
IMO, if the difference is just PUSH and PULL models, it's reasonable to merge them and improve. Any other ideas?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@vesense Thanks for your efforts~ \U0001f604
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by shroman <gi...@git.apache.org>.
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@vongosling There are two PRs for ROCKETMQ-81. I guess @hustfxj or @vesense will have to compile them in one, and they recheck it together :)
Guys, please make sure you assign JIRA issues to yourselves before you start working on tasks, and update them. For instance, @hustfxj if you are working on the issue, please change the status, so @vesense knows you are working on it and doesn't waste his time. Two pull requests are submitted but the issue has still "Open" status :D
In fact, I think it's pretty common to pick the issue and work on it if there is no progress on it for a long time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
I plan to merge these two PRs into one. @hustfxj What do you think about it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
Agree with @shroman .
But this two PRs are different implementations, based on PUSH and PULL models respectively, may be both can coexist.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@zhouxinyu Almost complete. I will submit it in this week. Some delay due to my computer wasn't working in the past few days. :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals issue #5: [ROCKETMQ-81] import rocketmq plugin ...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq-externals/pull/5
@dongeforever @shroman @stevenschew thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq-externals pull request #5: [ROCKETMQ-81] import rocketmq ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-rocketmq-externals/pull/5
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---