[GitHub] [tvm] hogepodge commented on a change in pull request #8825: refactor optimize GEMM on CPU tutorial

[GitBox <gi...@apache.org>]

hogepodge commented on a change in pull request #8825:
URL: https://github.com/apache/tvm/pull/8825#discussion_r699403043



##########
File path: tutorials/optimize/opt_gemm.py
##########
@@ -227,43 +228,49 @@
 ###################################################################################################
 # Array Packing
 # -------------
-# Another important trick is array packing. This trick is to reorder the storage dimension of the
-# array to convert the continuous access pattern on certain dimension to a sequential pattern after
+# Another important trick is array packing. This trick is to reorder the storage dimension of an
+# array to convert the continuous access pattern on its dimensions to a sequential pattern after

Review comment:
       I like the shorter sentence, but do you mean non-continuous though? Apologies for the late reply.

##########
File path: tutorials/optimize/opt_gemm.py
##########
@@ -227,43 +228,49 @@
 ###################################################################################################
 # Array Packing
 # -------------
-# Another important trick is array packing. This trick is to reorder the storage dimension of the
-# array to convert the continuous access pattern on certain dimension to a sequential pattern after
+# Another important trick is array packing. This trick is to reorder the storage dimension of an
+# array to convert the continuous access pattern on its dimensions to a sequential pattern after

Review comment:
       lgtm




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org