You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2019/02/07 23:23:51 UTC
Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/
-----------------------------------------------------------
Review request for mesos, Gastón Kleiman and Joseph Wu.
Bugs: MESOS-9538
https://issues.apache.org/jira/browse/MESOS-9538
Repository: mesos
Description
-------
This patch adds the new test
`AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
which verifies that when an operation is dropped on its
way to the agent, a framework will receive an
OPERATION_DROPPED status update if it requested feedback
for that operation.
Diffs
-----
src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69922/diff/1/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/#review212657
-----------------------------------------------------------
PASS: Mesos patch 69922 was successfully built and tested.
Reviews applied: `['69910', '69920', '69912', '69919', '69911', '69922']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2863/mesos-review-69922
- Mesos Reviewbot Windows
On Feb. 7, 2019, 11:23 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69922/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2019, 11:23 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joseph Wu.
>
>
> Bugs: MESOS-9538
> https://issues.apache.org/jira/browse/MESOS-9538
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the new test
> `AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
> which verifies that when an operation is dropped on its
> way to the agent, a framework will receive an
> OPERATION_DROPPED status update if it requested feedback
> for that operation.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69922/diff/1/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/#review212663
-----------------------------------------------------------
PASS: Mesos patch 69922 was successfully built and tested.
Reviews applied: `['69910', '69920', '69912', '69919', '69911', '69922']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2865/mesos-review-69922
- Mesos Reviewbot Windows
On Feb. 8, 2019, 5:50 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69922/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2019, 5:50 a.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joseph Wu.
>
>
> Bugs: MESOS-9538
> https://issues.apache.org/jira/browse/MESOS-9538
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the new test
> `AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
> which verifies that when an operation is dropped on its
> way to the agent, a framework will receive an
> OPERATION_DROPPED status update if it requested feedback
> for that operation.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69922/diff/4/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/
-----------------------------------------------------------
(Updated Feb. 8, 2019, 5:50 a.m.)
Review request for mesos, Gastón Kleiman and Joseph Wu.
Bugs: MESOS-9538
https://issues.apache.org/jira/browse/MESOS-9538
Repository: mesos
Description
-------
This patch adds the new test
`AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
which verifies that when an operation is dropped on its
way to the agent, a framework will receive an
OPERATION_DROPPED status update if it requested feedback
for that operation.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69922/diff/4/
Changes: https://reviews.apache.org/r/69922/diff/3-4/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/#review212658
-----------------------------------------------------------
PASS: Mesos patch 69922 was successfully built and tested.
Reviews applied: `['69910', '69920', '69912', '69919', '69911', '69922']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2864/mesos-review-69922
- Mesos Reviewbot Windows
On Feb. 8, 2019, 1:44 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69922/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2019, 1:44 a.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joseph Wu.
>
>
> Bugs: MESOS-9538
> https://issues.apache.org/jira/browse/MESOS-9538
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the new test
> `AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
> which verifies that when an operation is dropped on its
> way to the agent, a framework will receive an
> OPERATION_DROPPED status update if it requested feedback
> for that operation.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69922/diff/3/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/
-----------------------------------------------------------
(Updated Feb. 8, 2019, 1:44 a.m.)
Review request for mesos, Gastón Kleiman and Joseph Wu.
Bugs: MESOS-9538
https://issues.apache.org/jira/browse/MESOS-9538
Repository: mesos
Description
-------
This patch adds the new test
`AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
which verifies that when an operation is dropped on its
way to the agent, a framework will receive an
OPERATION_DROPPED status update if it requested feedback
for that operation.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69922/diff/3/
Changes: https://reviews.apache.org/r/69922/diff/2-3/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/
-----------------------------------------------------------
(Updated Feb. 8, 2019, 1:29 a.m.)
Review request for mesos, Gastón Kleiman and Joseph Wu.
Bugs: MESOS-9538
https://issues.apache.org/jira/browse/MESOS-9538
Repository: mesos
Description
-------
This patch adds the new test
`AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
which verifies that when an operation is dropped on its
way to the agent, a framework will receive an
OPERATION_DROPPED status update if it requested feedback
for that operation.
Diffs (updated)
-----
src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/69922/diff/2/
Changes: https://reviews.apache.org/r/69922/diff/1-2/
Testing
-------
`bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
Thanks,
Greg Mann
Re: Review Request 69922: Added test to verify that frameworks receive
OPERATION_DROPPED updates.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69922/#review212653
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/agent_operation_feedback_tests.cpp
Lines 564 (patched)
<https://reviews.apache.org/r/69922/#comment298500>
Can we also check that the agent ID is set and that the RP ID isn't?
- Gastón Kleiman
On Feb. 7, 2019, 3:23 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69922/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2019, 3:23 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Joseph Wu.
>
>
> Bugs: MESOS-9538
> https://issues.apache.org/jira/browse/MESOS-9538
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds the new test
> `AgentOperationFeedbackTest.DroppedOperationStatusUpdate`
> which verifies that when an operation is dropped on its
> way to the agent, a framework will receive an
> OPERATION_DROPPED status update if it requested feedback
> for that operation.
>
>
> Diffs
> -----
>
> src/tests/agent_operation_feedback_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/69922/diff/1/
>
>
> Testing
> -------
>
> `bin/mesos-tests.sh --gtest_filter="*DroppedOperationStatusUpdate*" --gtest_repeat=-1 --gtest_break_on_failure`
>
>
> Thanks,
>
> Greg Mann
>
>